Merge pull request #9391 from kbrock/arel_sql_helper

Use Arel.sql to statically cast sql

Author: Fryguy

app/services/cloud_tenant_dashboard_service.rb

@@ -102,8 +102,7 @@ def recent_resources(model, title, label, relation)
 
   def recent_records(model, relation)
     db_table     = model.arel_table
-    to_char_args = [db_table[:created_on], Arel::Nodes::SqlLiteral.new("'YYYY-MM-DD'")]
-    group_by_sql = Arel::Nodes::NamedFunction.new("to_char", to_char_args)
+    group_by_sql = Arel::Nodes::NamedFunction.new("to_char", [db_table[:created_on], Arel.sql("'YYYY-MM-DD'")])
 
     relation.where(db_table[:created_on].gt(30.days.ago.utc))
             .group(group_by_sql.to_sql)

app/services/ems_dashboard_service.rb

@@ -53,8 +53,7 @@ def recent_resources(model, title, label)
   #   }
   def recent_records(model)
     db_table     = model.arel_table
-    to_char_args = [db_table[:created_on], Arel::Nodes::SqlLiteral.new("'YYYY-MM-DD'")]
-    group_by_sql = Arel::Nodes::NamedFunction.new("to_char", to_char_args)
+    group_by_sql = Arel::Nodes::NamedFunction.new("to_char", [db_table[:created_on], Arel.sql("'YYYY-MM-DD'")])
 
     model.where(:ems_id => @ems.id)
          .where(db_table[:created_on].gt(30.days.ago.utc))