Merge pull request #9411 from jrafanie/dead-code

Remove dead code

Author: GilbertCherrie

app/javascript/oldjs/services/miq_service.js

@@ -27,10 +27,6 @@ ManageIQ.angular.app.service('miqService', ['$q', 'API', '$window', function($q,
     miqJqueryRequest(url, {beforeSend: true, data: serializeFields});
   };
 
-  this.restAjaxButton = function(url, button, dataType, data) {
-    miqRESTAjaxButton(url, button, dataType, data);
-  };
-
   this.jqueryRequest = function(url, options) {
     return miqJqueryRequest(url, options);
   };
@@ -69,12 +65,6 @@ ManageIQ.angular.app.service('miqService', ['$q', 'API', '$window', function($q,
     return form.$valid && form.$dirty;
   };
 
-  this.detectWithRest = function($event, url) {
-    angular.element('#button_name').val('detect');
-    miqSparkleOn();
-    return $q.when(miqRESTAjaxButton(url, $event.target, 'json'));
-  };
-
   this.networkProviders = function(options) {
     options = Object.assign(options || {}, {
       attributes: ['id', 'name'],
@@ -97,34 +87,6 @@ ManageIQ.angular.app.service('miqService', ['$q', 'API', '$window', function($q,
       .catch(options.handleFailure);
   };
 
-  this.validateWithAjax = function(url, model) {
-    miqSparkleOn();
-    miqAjaxButton(url, model || true);
-  };
-
-  this.validateWithREST = function($event, credType, url, formSubmit) {
-    angular.element('#button_name').val('validate');
-    angular.element('#cred_type').val(credType);
-    if (formSubmit) {
-      miqSparkleOn();
-      return $q.when(miqRESTAjaxButton(url, $event.target, 'json'));
-    }
-    $event.preventDefault();
-  };
-
-  this.validateClicked = function($event, authType, formSubmit, angularForm, url) {
-    miqService.validateWithREST($event, authType, url, formSubmit)
-      .then(function success(data) {
-        if (data.level === 'error') {
-          angularForm.default_auth_status.$setViewValue(false);
-        } else {
-          angularForm.default_auth_status.$setViewValue(true);
-        }
-        miqService.miqFlash(data.level, data.message);
-        miqService.sparkleOff();
-      });
-  };
-
   this.disabledClick = function($event) {
     $event.preventDefault();
   };

spec/javascripts/services/miq_service_spec.js

@@ -154,34 +154,6 @@ describe('miqService', function() {
     });
   });
 
-  describe('#validateWithREST', function() {
-    beforeEach(function() {
-      testService.validateWithREST($.Event, "default", '/ems_cloud/create/new?button=validate&type=default', true);
-    });
-
-    it('turns the spinner on via the miqService', function() {
-      expect(window.miqSparkleOn).toHaveBeenCalled();
-    });
-
-    it('delegates to miqService.miqAjaxButton', function() {
-      expect(window.miqAjaxButton).toHaveBeenCalledWith('/ems_cloud/create/new?button=validate&type=default', true);
-    });
-  });
-
-  describe('#validateWithAjax', function() {
-    beforeEach(function() {
-      testService.validateWithAjax('/host/create/new?button=validate&type=default');
-    });
-
-    it('turns the spinner on via the miqService', function() {
-      expect(window.miqSparkleOn).toHaveBeenCalled();
-    });
-
-    it('delegates to miqService.miqAjaxButton', function() {
-      expect(window.miqAjaxButton).toHaveBeenCalledWith('/host/create/new?button=validate&type=default', true);
-    });
-  });
-
   describe('#disabledClick', function() {
     it('prevents a submit action', function() {
       var event = $.Event('click');