Skip to content

Commit a3e98c3

Browse files
Replaced inline flash message checks with reusable expect_flash command
1 parent c966ddc commit a3e98c3

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

cypress/e2e/ui/Settings/Application-Settings/edit_collect_logs.cy.js

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const textConstants = {
3636

3737
// Flash message text snippets
3838
flashMessageSettingsSaved: 'saved',
39-
flashMessageOperationCanceled: 'cancelled',
39+
flashMessageOperationCanceled: 'cancel',
4040
};
4141

4242
const {
@@ -174,9 +174,7 @@ function resetProtocolDropdown({
174174
cy.wrap($select).select(dropdownBlankValue);
175175
cy.contains(buttonSelector(submitButtonType), saveButton).click();
176176
// Validating confirmation flash message
177-
cy.get('#main_div #flash_msg_div .alert-success').contains(
178-
'Log Depot Settings were saved'
179-
);
177+
cy.expect_flash(flashTypeSuccess, flashMessageSettingsSaved);
180178
}
181179
}
182180
);
@@ -198,10 +196,8 @@ function cancelButtonValidation() {
198196
cy.contains(buttonSelector(normalButtonType), cancelButton)
199197
.should('be.enabled')
200198
.click();
201-
// Validating confirmation alert text displayed
202-
cy.get('#main_div #flash_msg_div .alert-success').contains(
203-
'Edit Log Depot settings was cancelled by the user'
204-
);
199+
// Validating confirmation flash message
200+
cy.expect_flash(flashTypeSuccess, flashMessageOperationCanceled);
205201
}
206202

207203
function resetButtonValidation() {
@@ -238,10 +234,8 @@ function saveButtonValidation() {
238234
cy.contains(buttonSelector(submitButtonType), saveButton)
239235
.should('be.enabled')
240236
.click();
241-
// Validating confirmation alert text displayed
242-
cy.get('#main_div #flash_msg_div .alert-success').contains(
243-
'Log Depot Settings were saved'
244-
);
237+
// Validating confirmation flash message
238+
cy.expect_flash(flashTypeSuccess, flashMessageSettingsSaved);
245239
}
246240

247241
describe('Automate Collect logs Edit form operations', () => {

0 commit comments

Comments
 (0)