Inline a singly-used helper into vm_common

Author: Fryguy

app/controllers/vm_common.rb

@@ -76,7 +76,7 @@ def button
       javascript_flash(:spinner_off => true)
     else
       options
-      partial_replace(@refresh_div, "vm_common/#{@refresh_partial}")
+      "$(\"##{h(@refresh_div)}\").replaceWith(\"#{escape_javascript(render(:partial => "vm_common/#{@refresh_partial}"))}\");".html_safe
     end
   end
 
@@ -580,7 +580,7 @@ def remove_service
 
   def edit
     @record = find_record_with_rbac(VmOrTemplate, params[:id]) # Set the VM object
-    
+
     # reset @explorer if coming from explorer views
     @edit ||= {}
     @edit[:explorer] = true if params[:action] == "x_button" || session.fetch_path(:edit, :explorer)

app/helpers/js_helper.rb

@@ -42,10 +42,6 @@ def javascript_hide_if_exists(element)
     "if (miqDomElementExists('#{j_str(element)}')) #{javascript_hide(element)}".html_safe
   end
 
-  def partial_replace(from, partial, locals)
-    "$(\"##{h(from)}\").replaceWith(\"#{escape_javascript(render(:partial => partial, :locals => locals))}\");".html_safe
-  end
-
   def javascript_checked(element)
     "if ($('##{j_str(element)}').prop('type') == 'checkbox') {$('##{j_str(element)}').prop('checked', true);}"
       .html_safe