Skip to content

Commit de11a24

Browse files
committed
Removes commented lines
1 parent 7dd0b99 commit de11a24

File tree

6 files changed

+7
-35
lines changed

6 files changed

+7
-35
lines changed

app/controllers/miq_ae_class_controller.rb

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require "rexml/document"
2-
require 'byebug'
32
class MiqAeClassController < ApplicationController
43
include MiqAeClassHelper
54
include AutomateTreeHelper
@@ -883,19 +882,11 @@ def fields_form_field_changed
883882

884883
fields_get_form_vars
885884
@changed = (@edit[:new] != @edit[:current])
886-
# render :update do |page|
887-
# page << javascript_prologue
888885
unless %w[up down].include?(params[:button])
889886
if params[:field_datatype] == "password"
890-
# page << javascript_hide("field_default_value")
891-
# page << javascript_show("field_password_value")
892-
# page << "$('#field_password_value').val('');"
893887
session[:field_data][:default_value] =
894888
@edit[:new_field][:default_value] = ''
895889
elsif params[:field_datatype]
896-
# page << javascript_hide("field_password_value")
897-
# page << javascript_show("field_default_value")
898-
# page << "$('#field_default_value').val('');"
899890
session[:field_data][:default_value] =
900891
@edit[:new_field][:default_value] = ''
901892
end
@@ -906,19 +897,11 @@ def fields_form_field_changed
906897
def_field = "fields_default_value_" << f[1].to_s
907898
pwd_field = "fields_password_value_" << f[1].to_s
908899
if @edit[:new][:fields][f[1].to_i]['datatype'] == "password"
909-
# page << javascript_hide(def_field)
910-
# page << javascript_show(pwd_field)
911-
# page << "$('##{pwd_field}').val('');"
912900
else
913-
# page << javascript_hide(pwd_field)
914-
# page << javascript_show(def_field)
915-
# page << "$('##{def_field}').val('');"
916901
end
917902
@edit[:new][:fields][f[1].to_i]['default_value'] = nil
918903
end
919904
end
920-
# page << javascript_for_miq_button_visibility_changed(@changed)
921-
# end
922905
render :json => {:message => 'Field updated successfully'}, :status => 200
923906
end
924907

@@ -1440,7 +1423,7 @@ def create_namespace
14401423
# AJAX driven routine to select a classification entry
14411424
def field_select
14421425
assert_privileges('miq_ae_field_edit')
1443-
fields_get_form_vars # nothing in particular handled here
1426+
fields_get_form_vars
14441427
session[:field_data] = {}
14451428
@edit[:new_field][:substitute] = session[:field_data][:substitute] = true
14461429
render :json => {:status => 200}
@@ -2368,23 +2351,17 @@ def fields_get_form_vars
23682351
end
23692352
end
23702353
elsif params[:button] == "accept"
2371-
# if session[:field_data][:name].blank? || session[:field_data][:aetype].blank?
23722354
if params[:name].blank? || params[:aetype].blank?
2373-
# field = session[:field_data][:name].blank? ? "Name" : "Type"
2374-
# field += " and Type" if field == "Name" && session[:field_data][:aetype].blank?
23752355
field = params[:name].blank? ? "Name" : "Type"
23762356
field += " and Type" if field == "Name" && params[:aetype].blank?
23772357
add_flash(_("%{field} is required") % {:field => field}, :error)
23782358
return
23792359
end
23802360
new_fields = {}
23812361
field_attributes.each do |field_attribute|
2382-
# new_fields[field_attribute] = @edit[:new_field][field_attribute.to_sym]
2383-
# new_fields[field_attribute] = params[:field][field_attribute.to_sym]
23842362
new_fields[field_attribute] = params[field_attribute.to_sym]
23852363
end
23862364
@edit[:new][:fields].push(new_fields)
2387-
# @edit[:new_field] = session[:field_data] = {}
23882365
end
23892366
end
23902367

app/javascript/components/data-tables/datastore/helper.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
import { headerData, rowData } from '../../miq-data-table/helper';
2-
// import miqFlash from '../../helpers/miq-flash';
3-
// import miqFlashClear from '../../helpers/miq-flash-clear';
42

53
const hasCheckbox = (type, { domain, schema, fields }) => ![domain, schema, fields].includes(type);
64

app/javascript/components/data-tables/datastore/schema/class-fields-editor.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export const ClassFieldsEditor = (props) => {
142142
updateState(data);
143143
})
144144
.catch((error) => {
145-
console.error('Failed to save new field:', error);
145+
// console.error('Failed to save new field:', error);
146146
});
147147
}
148148
};

app/javascript/components/data-tables/datastore/schema/class-fields-schema.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,15 @@ const createSchemaEditSchema = (rows, setState, isSchemaModified) => {
1313
}));
1414
})
1515
.catch((error) => {
16-
console.error('Failed to add new field:', error);
16+
// console.error('Failed to add new field:', error);
1717
});
1818
};
1919

2020
const handleFieldDelete = (rowId) => {
2121
const field = rows.find((field) => field.id === rowId);
22-
// const field = rows.find((field, rowIndex) => rowIndex === index);
2322
const arrId = rows.findIndex((field) => field.id === rowId);
2423
const fId = field.field_id;
2524
const url = `/miq_ae_class/field_delete${fId ? `/${fId}` : ''}?arr_id=${arrId}`;
26-
// const url = `/miq_ae_class/field_delete${fId ? `/${fId}` : ''}?arr_id=${rowId}`;
2725
http.post(url, { skipErrors: [400] })
2826
.then(() => {
2927
setState((prev) => ({
@@ -33,7 +31,7 @@ const createSchemaEditSchema = (rows, setState, isSchemaModified) => {
3331
}));
3432
})
3533
.catch((error) => {
36-
console.error('Failed to delete field:', error);
34+
// console.error('Failed to delete field:', error);
3735
});
3836
};
3937

@@ -52,7 +50,6 @@ const createSchemaEditSchema = (rows, setState, isSchemaModified) => {
5250
rows,
5351
headers: schemaHeaders(true),
5452
onCellClick: (selectedRow) => {
55-
debugger
5653
switch (selectedRow.callbackAction) {
5754
case 'editClassField':
5855
setState((prev) => ({

app/javascript/components/data-tables/datastore/schema/schema-table.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const SchemaTableComponent = (props) => {
1111
const formOptions = useFormApi();
1212

1313
useEffect(() => {
14-
input.onChange(rows); // Whenever props.rows changes, inform the form
14+
input.onChange(rows);
1515
}, [rows]);
1616

1717
return (
@@ -51,4 +51,4 @@ export const SchemaTableComponent = (props) => {
5151
</div>
5252
</div>
5353
);
54-
};
54+
};

app/views/miq_ae_class/_class_fields.html.haml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@
1010
:locals => {:message => _("No schema found")}
1111

1212
- else
13-
= render :partial => 'datastore_list', :locals => {:type => MiqAeClassHelper::DATASTORE_TYPES[:schema], :data => @ae_class.ae_fields}
13+
= render :partial => 'datastore_list', :locals => {:type => MiqAeClassHelper::DATASTORE_TYPES[:schema], :data => @ae_class.ae_fields}

0 commit comments

Comments
 (0)