Replaced inline flash message checks with reusable expect_flash command

Author: asirvadAbrahamVarghese

cypress/e2e/ui/Settings/Application-Settings/edit_collect_logs.cy.js

@@ -23,6 +23,13 @@ const textConstants = {
 
   // Component route url
   componentRouteUrl: '/ops/explorer',
+
+  // Flash message types
+  flashTypeSuccess: 'success',
+
+  // Flash message text snippets
+  flashMessageSettingsSaved: 'saved',
+  flashMessageOperationCanceled: 'cancelled',
 };
 
 const {
@@ -39,6 +46,9 @@ const {
   zoneAccordItem,
   serverAccordItem,
   componentRouteUrl,
+  flashTypeSuccess,
+  flashMessageSettingsSaved,
+  flashMessageOperationCanceled,
 } = textConstants;
 
 function invokeAndAwaitDiagnosticsInfo() {
@@ -171,9 +181,8 @@ function resetProtocolDropdown({
         cy.get('#diagnostics_collect_logs .bx--btn-set button[type="Submit"]')
           .contains(saveButton)
           .click();
-        cy.get('#main_div #flash_msg_div .alert-success').contains(
-          'Log Depot Settings were saved'
-        );
+        // Validating confirmation flash message
+        cy.expect_flash(flashTypeSuccess, flashMessageSettingsSaved);
       }
     }
   );
@@ -185,10 +194,8 @@ function cancelButtonValidation() {
     .contains(cancelButton)
     .should('be.enabled')
     .click();
-  // Validating confirmation alert text displayed
-  cy.get('#main_div #flash_msg_div .alert-success').contains(
-    'Edit Log Depot settings was cancelled by the user'
-  );
+  // Validating confirmation flash message
+  cy.expect_flash(flashTypeSuccess, flashMessageOperationCanceled);
 }
 
 function resetButtonValidation() {
@@ -226,10 +233,8 @@ function saveButtonValidation() {
     .contains(saveButton)
     .should('be.enabled')
     .click();
-  // Validating confirmation alert text displayed
-  cy.get('#main_div #flash_msg_div .alert-success').contains(
-    'Log Depot Settings were saved'
-  );
+  // Validating confirmation flash message
+  cy.expect_flash(flashTypeSuccess, flashMessageSettingsSaved);
 }
 
 describe('Automate Collect logs Edit form operations', () => {