-
Notifications
You must be signed in to change notification settings - Fork 365
Openshift volume Attach/Detach #9521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Checked commits chitra607/manageiq-ui-classic@9297892~...d1f700d with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint app/controllers/vm_common.rb
app/controllers/vm_infra_controller.rb
app/helpers/application_helper/button/vm_attach_volume.rb
app/helpers/application_helper/button/vm_detach_volume.rb
app/views/vm_common/_add_volume.html.haml
app/views/vm_common/_remove_volume.html.haml
|
@chitra607 I think we want to use VM Reconfigure for this so it would fit in to existing UI / API flows and not need anything extra here |
def storage_class_list | ||
vm = find_record_with_rbac(VmOrTemplate, params[:id]) | ||
ems = vm.ext_management_system | ||
storage_class = vm.storage_classes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE storage_classes isn't something that we currently have. We would need to collect them in inventory refresh as part of the provider and persist them in the database for this to work. We do currently have a StorageProfile
model which we could use to store these without having to create a new table/model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agrare. Just to clarify, storage_classes here is a function I added that fetches the list directly from the OpenShift/KubeVirt API at runtime, it is not a table/model. Would it make sense to use the existing StorageProfile model to persist storage classes list in OpenShift/KubeVirt as you suggested?
No description provided.