Skip to content

Commit b90586d

Browse files
authored
Merge pull request #1775 from Fryguy/hardcode_novnc_version
Temporarily hardcode the novnc version
2 parents 1e29198 + 1c4879a commit b90586d

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

config/webpack.dev.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,13 @@ module.exports = {
190190
// noVNC doesn't package the vnc_lite viewer that we need, so we have to
191191
// fetch it separately.
192192
new SaveRemoteFilePlugin({
193-
url: `https://raw.githubusercontent.com/novnc/noVNC/v${execSync(`yarn info --name-only @novnc/novnc | cut -d ':' -f 2 | tr -d '\n'`, {encoding: 'utf-8'})}/vnc_lite.html`,
193+
// HACK: Temporarily hardcoded the version number for @novnc/novnc, because
194+
// the following, which works locally, does not work for some reason
195+
// in CI. Any changes to package.json for this package will also
196+
// need to be changed here.
197+
// url: `https://raw.githubusercontent.com/novnc/noVNC/v${execSync(`yarn info --name-only @novnc/novnc | cut -d ':' -f 2 | tr -d '\n'`, {encoding: 'utf-8'})}/vnc_lite.html`,
198+
url: `https://raw.githubusercontent.com/novnc/noVNC/v1.2.0/vnc_lite.html`,
199+
194200
filepath: 'vendor/noVNC/vnc_lite.html',
195201
hash: false
196202
}),

0 commit comments

Comments
 (0)