Change EvmServer#find_vms_by... tests

Author: kbrock

spec/lib/workers/evm_server_spec.rb

@@ -189,46 +189,89 @@
     end
   end
 
+  let(:hostname) { "ABCDEFG" }
+  let(:address) { "AB:CD:EF:GH" }
+  let(:vm1_network) { FactoryBot.create(:network, :hostname => hostname) }
+  let(:vm2_network) { FactoryBot.create(:network) }
+  let(:vm3_device) { FactoryBot.create(:guest_device, :address => address, :device_type => "ethernet") }
+  let(:vm1) { FactoryBot.create(:vm_vmware, :hardware => FactoryBot.create(:hardware, :networks => [vm1_network])) }
+  let(:vm2) { FactoryBot.create(:vm_vmware, :hardware => FactoryBot.create(:hardware, :networks => [vm2_network])) }
+  let(:vm3) { FactoryBot.create(:vm_vmware, :hardware => FactoryBot.create(:hardware, :guest_devices => [vm3_device])) }
+
   context "#find_vms_by_mac_address_and_hostname_and_ipaddress (private)" do
     subject { described_class.new }
-    before do
-      @hardware1 = FactoryBot.create(:hardware)
-      @vm1 = FactoryBot.create(:vm_vmware, :hardware => @hardware1)
-
-      @hardware2 = FactoryBot.create(:hardware)
-      @vm2 = FactoryBot.create(:vm_vmware, :hardware => @hardware2)
-    end
 
     it "mac_address" do
-      address = "ABCDEFG"
-      guest_device = FactoryBot.create(:guest_device, :address => address, :device_type => "ethernet")
-      @hardware1.guest_devices << guest_device
-
-      expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, address, nil, nil))
-        .to eql([@vm1])
+      vm1
+      vm2
+      vm3
+      subject
+
+      expect do
+        expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, address, nil, nil)).to eq([vm3])
+      end.to make_database_queries(:count => 1)
     end
 
     it "hostname" do
-      hostname = "ABCDEFG"
-      network = FactoryBot.create(:network, :hostname => hostname)
-      @hardware1.networks << network
+      vm1
+      vm2
+      subject
 
-      expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, nil, hostname, nil))
-        .to eql([@vm1])
+      expect do
+        expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, nil, hostname, nil)).to eq([vm1])
+      end.to make_database_queries(:count => 1)
     end
 
     it "ipaddress" do
-      ipaddress = "127.0.0.1"
-      network = FactoryBot.create(:network, :ipaddress => ipaddress)
-      @hardware1.networks << network
+      vm1
+      vm2
+      subject
+
+      expect do
+        expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, nil, nil, vm1_network.ipaddress)).to eq([vm1])
+      end.to make_database_queries(:count => 1)
+    end
+
+    it "hostname and ipaddress" do
+      vm1
+      vm2
+      subject
 
-      expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, nil, nil, ipaddress))
-        .to eql([@vm1])
+      expect do
+        expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, nil, vm1_network.hostname, vm1_network.ipaddress)).to eq([vm1])
+      end.to make_database_queries(:count => 1)
+    end
+
+    it "hostname and different ipaddress" do
+      vm1
+      vm2
+      subject
+
+      expect do
+        expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, nil, vm1_network.hostname, vm2_network.ipaddress)).to be_empty
+      end.to make_database_queries(:count => 1)
+    end
+
+    # vm must match both mac address and a hostname from a single server
+    # not sure if that was the original intent, but how the code currently works
+    it "mac address and different hostname" do
+      vm1
+      vm3
+      subject
+
+      expect do
+        expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, address, vm1_network.hostname, nil)).to be_empty
+      end.to make_database_queries(:count => 1)
     end
 
     it "returns an empty list when all are blank" do
-      expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, nil, nil, nil)).to eq([])
-      expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, '', '', '')).to eq([])
+      vm1
+      subject
+
+      expect do
+        expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, nil, nil, nil)).to eq([])
+        expect(subject.send(:find_vms_by_mac_address_and_hostname_and_ipaddress, '', '', '')).to eq([])
+      end.not_to make_database_queries
     end
   end
 end