Don't include all types in Vm children

Before
======

```
vmdb(dev)> puts Vm.all.to_sql
SELECT "vms".* FROM "vms"
WHERE "vms"."type" IN ('Vm', 'VmServer',
  'ManageIQ::Providers::PhysicalInfraManager::Vm', 'ManageIQ::Providers::InfraManager::Vm',
  'ManageIQ::Providers::CloudManager::Vm', 'ManageIQ::Providers::CiscoIntersight::PhysicalInfraManager::Vm',
  'ManageIQ::Providers::Vmware::InfraManager::Vm', 'ManageIQ::Providers::Ovirt::InfraManager::Vm',
  'ManageIQ::Providers::Nutanix::InfraManager::Vm', 'ManageIQ::Providers::Kubevirt::InfraManager::Vm',
  'ManageIQ::Providers::IbmPowerHmc::InfraManager::Vm', 'ManageIQ::Providers::Redhat::InfraManager::Vm',
  'ManageIQ::Providers::Openshift::InfraManager::Vm', 'ManageIQ::Providers::IbmPowerHmc::InfraManager::Vios',
  'ManageIQ::Providers::IbmPowerHmc::InfraManager::Lpar', 'ManageIQ::Providers::Vmware::CloudManager::Vm',
  'ManageIQ::Providers::OracleCloud::CloudManager::Vm', 'ManageIQ::Providers::Openstack::CloudManager::Vm',
  'ManageIQ::Providers::IbmCloud::VPC::CloudManager::Vm', 'ManageIQ::Providers::IbmCloud::PowerVirtualServers::CloudManager::Vm',
  'ManageIQ::Providers::Google::CloudManager::Vm', 'ManageIQ::Providers::AzureStack::CloudManager::Vm',
  'ManageIQ::Providers::Azure::CloudManager::Vm', 'ManageIQ::Providers::Amazon::CloudManager::Vm',
  'ManageIQ::Providers::IbmPowerVc::CloudManager::Vm', 'ManageIQ::Providers::IbmCic::CloudManager::Vm')
  AND "vms"."template" = FALSE
=> nil
vmdb(dev)> puts ManageIQ::Providers::Vmware::InfraManager::Vm.all.to_sql
SELECT "vms".* FROM "vms"
WHERE "vms"."type" = 'ManageIQ::Providers::Vmware::InfraManager::Vm'
  AND "vms"."template" = FALSE
```

After
=====

```
vmdb(dev)> puts Vm.all.to_sql
SELECT "vms".* FROM "vms"
WHERE "vms"."template" = FALSE
=> nil
vmdb(dev)> puts ManageIQ::Providers::Vmware::InfraManager::Vm.all.to_sql
SELECT "vms".* FROM "vms"
WHERE "vms"."type" = 'ManageIQ::Providers::Vmware::InfraManager::Vm'
```

Author: kbrock

app/models/miq_template.rb

@@ -12,6 +12,28 @@ class MiqTemplate < VmOrTemplate
 
   include Operations
 
+  def self.finder_needs_type_condition?
+    false
+  end
+
+  def self.default_scope
+    where(:template => true)
+  end
+
+  def self.inherited(subclass)
+    super
+    # if you are inheriting from top level class (i.e.: Vm), then use type instead of template
+    unless self.name.to_s.include?(":")
+      subclass.instance_eval do
+        def self.finder_needs_type_condition?
+          true
+        end
+        def self.default_scope
+        end
+      end
+    end
+  end
+
   def self.base_model
     MiqTemplate
   end

app/models/vm.rb

@@ -1,5 +1,4 @@
 class Vm < VmOrTemplate
-  default_scope { where(:template => false) }
   virtual_has_one :supported_consoles, :class_name => "Hash"
 
   extend InterRegionApiMethodRelay
@@ -10,6 +9,29 @@ class Vm < VmOrTemplate
 
   include Operations
 
+  # Don't tack on type query for this class (instead we use scope)
+  def self.finder_needs_type_condition?
+    false
+  end
+
+  def self.default_scope
+    where(:template => false)
+  end
+
+  def self.inherited(subclass)
+    super
+    # if you are inheriting from top level class (i.e.: Vm), then use type instead of template
+    unless self.name.to_s.include?(":")
+      subclass.instance_eval do
+        def self.finder_needs_type_condition?
+          true
+        end
+        def self.default_scope
+        end
+      end
+    end
+  end
+
   def self.base_model
     Vm
   end