Skip to content

Commit 8f2bb7e

Browse files
authored
Merge pull request #23634 from jrafanie/fix-minor-typos
Fix some minor typos when I noticed 'taget'
2 parents 49d37cc + 9526ac8 commit 8f2bb7e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/rbac/filterer.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module Rbac
22
class PolymorphicError < ArgumentError; end
33

44
class Filterer
5-
# This list is used to detemine whether RBAC, based on assigned tags, should be applied for a class in a search that is based on the class.
5+
# This list is used to determine whether RBAC, based on assigned tags, should be applied for a class in a search that is based on the class.
66
# Classes should be added to this list ONLY after:
77
# 1. Tagging has been enabled in the UI
88
# 2. Class contains acts_as_miq_taggable
@@ -356,7 +356,7 @@ def search(options = {})
356356
targets = targets.lazy.select { |obj| matches_search_filters?(obj, search_filter, tz, :prune_sql => prune_sql) }
357357
unless options[:skip_counts]
358358
# use to_a to run filters once. otherwise will filter for:
359-
# length, (possible) pagination ids, and final taget results
359+
# length, (possible) pagination ids, and final target results
360360
targets = targets.to_a
361361
auth_count = targets.length
362362
end
@@ -490,7 +490,7 @@ def apply_rbac_through_association?(klass)
490490

491491
# get the base class for a class
492492
#
493-
# rbac_class().nil? checks are there to avoid promoting to a base class when the child class is supported by base class is not
493+
# rbac_class().nil? checks are there to avoid promoting to a base class when the child class is supported but base class is not
494494
# Read: child: MiqAeDomain (supported) to base: MiqAeNamespace (not supported)
495495
def rbac_base_class(klass)
496496
if klass.respond_to?(:base_class) && rbac_class(klass).nil? && rbac_class(klass.base_class)
@@ -561,7 +561,7 @@ def calc_filtered_ids(scope, user_filters, user, miq_group, scope_tenant_filter)
561561
# filter = u_union_d_union_b_and_m INTERSECTION tenant_filter_ids
562562
#
563563
# a nil as input for any field means it DOES NOT apply the operation(INTERSECTION, UNION)
564-
# a nil as output means there is not filter
564+
# a nil as output means there is no filter
565565
#
566566
# @param u_filtered_ids [nil|Array<Integer>] self service user owned objects
567567
# @param b_filtered_ids [nil|Array<Integer>] objects that belong to parent

0 commit comments

Comments
 (0)