Add deprecation message for Keycloak (argoproj-labs#1759)

* Add deprecation message for Keycloak

Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>

* Rebase to latest from master branch

Signed-off-by: Jonathan West <jonwest@redhat.com>

---------

Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Co-authored-by: Jonathan West <jonwest@redhat.com>

Author: Rizwana777

api/v1alpha1/argocd_types.go

@@ -636,6 +636,7 @@ type ArgoCDSSOSpec struct {
 	Dex *ArgoCDDexSpec `json:"dex,omitempty"`
 
 	// Keycloak contains the configuration for Argo CD keycloak authentication
+	// Deprecated: This field is planned for removal in a future release and will no longer be supported.
 	Keycloak *ArgoCDKeycloakSpec `json:"keycloak,omitempty"`
 
 	// Deprecated field. Support dropped in v1beta1 version.

bundle/manifests/argoproj.io_argocds.yaml

@@ -7111,8 +7111,9 @@ spec:
                       Image is the SSO container image.
                     type: string
                   keycloak:
-                    description: Keycloak contains the configuration for Argo CD keycloak
-                      authentication
+                    description: |-
+                      Keycloak contains the configuration for Argo CD keycloak authentication
+                      Deprecated: This field is planned for removal in a future release and will no longer be supported.
                     properties:
                       host:
                         description: Host is the hostname to use for Ingress/Route

config/crd/bases/argoproj.io_argocds.yaml

@@ -7100,8 +7100,9 @@ spec:
                       Image is the SSO container image.
                     type: string
                   keycloak:
-                    description: Keycloak contains the configuration for Argo CD keycloak
-                      authentication
+                    description: |-
+                      Keycloak contains the configuration for Argo CD keycloak authentication
+                      Deprecated: This field is planned for removal in a future release and will no longer be supported.
                     properties:
                       host:
                         description: Host is the hostname to use for Ingress/Route

controllers/argocd/configmap.go

@@ -467,6 +467,7 @@ func (r *ReconcileArgoCD) reconcileArgoConfigMap(cr *argoproj.ArgoCD) error {
 			}
 			cm.Data[common.ArgoCDKeyDexConfig] = existingCM.Data[common.ArgoCDKeyDexConfig]
 		} else if cr.Spec.SSO != nil && cr.Spec.SSO.Provider.ToLower() == argoproj.SSOProviderTypeKeycloak {
+			log.Info("Keycloak SSO provider is deprecated and will be removed in a future release. Please migrate to Dex or another supported provider.")
 			// retain oidc.config during reconcilliation when keycloak is configured
 			cm.Data[common.ArgoCDKeyOIDCConfig] = existingCM.Data[common.ArgoCDKeyOIDCConfig]
 		}

controllers/argocd/sso.go

@@ -108,8 +108,8 @@ func (r *ReconcileArgoCD) reconcileSSO(cr *argoproj.ArgoCD) error {
 
 		// case 3
 		if cr.Spec.SSO.Provider.ToLower() == argoproj.SSOProviderTypeKeycloak {
+			log.Info("Keycloak SSO provider is deprecated and will be removed in a future release. Please migrate to Dex or another supported provider.")
 			// Relevant SSO settings at play are `.spec.sso.keycloak` fields, `.spec.sso.dex`
-
 			if cr.Spec.SSO.Dex != nil {
 				// new dex spec fields are expressed when `.spec.sso.provider` is set to keycloak ==> conflict
 				errMsg = "cannot supply dex configuration when requested SSO provider is keycloak"
@@ -173,6 +173,8 @@ func (r *ReconcileArgoCD) reconcileSSO(cr *argoproj.ArgoCD) error {
 	// keycloak
 	if cr.Spec.SSO != nil && cr.Spec.SSO.Provider.ToLower() == argoproj.SSOProviderTypeKeycloak {
 
+		log.Info("Keycloak SSO provider is deprecated and will be removed in a future release. Please migrate to Dex or another supported provider.")
+
 		// Trigger reconciliation of any Dex resources so they get deleted
 		if err := r.reconcileDexResources(cr); err != nil && !apiErrors.IsNotFound(err) {
 			log.Error(err, "Unable to delete existing dex resources before configuring keycloak")
@@ -205,6 +207,7 @@ func (r *ReconcileArgoCD) deleteSSOConfiguration(newCr *argoproj.ArgoCD, oldCr *
 	log.Info("uninstalling existing SSO configuration")
 
 	if oldCr.Spec.SSO.Provider.ToLower() == argoproj.SSOProviderTypeKeycloak {
+		log.Info("Keycloak SSO provider is deprecated and will be removed in a future release. Please migrate to Dex or another supported provider.")
 		if err := deleteKeycloakConfiguration(newCr); err != nil {
 			log.Error(err, "Unable to delete existing keycloak configuration")
 			return fmt.Errorf("unable to delete existing keycloak configuration. error: %w", err)

controllers/argocd/status.go

@@ -226,6 +226,7 @@ func (r *ReconcileArgoCD) reconcileStatusSSO(cr *argoproj.ArgoCD) error {
 		if cr.Spec.SSO != nil && cr.Spec.SSO.Provider.ToLower() == argoproj.SSOProviderTypeDex {
 			return r.reconcileStatusDex(cr)
 		} else if cr.Spec.SSO != nil && cr.Spec.SSO.Provider.ToLower() == argoproj.SSOProviderTypeKeycloak {
+			log.Info("Keycloak SSO provider is deprecated and will be removed in a future release. Please migrate to Dex or another supported provider.")
 			return r.reconcileStatusKeycloak(cr)
 		}
 	} else {

deploy/olm-catalog/argocd-operator/0.14.0/argoproj.io_argocds.yaml

@@ -7111,8 +7111,9 @@ spec:
                       Image is the SSO container image.
                     type: string
                   keycloak:
-                    description: Keycloak contains the configuration for Argo CD keycloak
-                      authentication
+                    description: |-
+                      Keycloak contains the configuration for Argo CD keycloak authentication
+                      Deprecated: This field is planned for removal in a future release and will no longer be supported.
                     properties:
                       host:
                         description: Host is the hostname to use for Ingress/Route