[E] Adjust text section node link view

Join against text_section_id to take advantage of optimized index
for building the associations.

Author: scryptmouse

api/Gemfile

@@ -27,6 +27,8 @@ gem "citeproc-ruby", "~> 1.1.0"
 gem "classy_enum", "~> 4.0.0"
 gem "cleanroom"
 gem "closure_tree", "~> 7.0"
+# Until Rails 7.1
+gem "composite_primary_keys", "~> 14.0.10"
 gem "crass", "~> 1.0.5"
 gem "csl-styles", "~> 1.0"
 gem "cssbeautify"

api/Gemfile.lock

@@ -169,6 +169,8 @@ GEM
       activerecord (>= 4.2.10)
       with_advisory_lock (>= 4.0.0)
     coderay (1.1.3)
+    composite_primary_keys (14.0.10)
+      activerecord (~> 7.0.2)
     concurrent-ruby (1.2.2)
     connection_pool (2.4.1)
     content_disposition (1.0.0)
@@ -880,6 +882,7 @@ DEPENDENCIES
   classy_enum (~> 4.0.0)
   cleanroom
   closure_tree (~> 7.0)
+  composite_primary_keys (~> 14.0.10)
   crass (~> 1.0.5)
   csl-styles (~> 1.0)
   css_parser (~> 1.0)

api/app/models/text_section_node.rb

@@ -41,10 +41,8 @@ class TextSectionNode < ApplicationRecord
 
   scope :sans_search_indexed, -> { where(search_indexed: false) }
 
-  has_many_readonly :text_section_node_links, -> { in_order }, inverse_of: :parent, foreign_key: :parent_id
-  has_many_readonly :ancestor_links, -> { in_reverse_order }, class_name: "TextSectionNodeLink", inverse_of: :child, foreign_key: :child_id
-
-  has_one_readonly :text_section_node_derivation, inverse_of: :text_section_node
+  has_many_readonly :text_section_node_links, -> { in_order }, inverse_of: :parent, primary_key: %i[text_section_id id], foreign_key: %i[text_section_id parent_id]
+  has_many_readonly :ancestor_links, -> { in_reverse_order }, class_name: "TextSectionNodeLink", inverse_of: :child, primary_key: %i[text_section_id id], foreign_key: %i[text_section_id child_id]
 
   has_many :parents, -> { terminal }, through: :ancestor_links, source: :parent
   has_many :children, through: :text_section_node_links, source: :child
@@ -58,8 +56,6 @@ class TextSectionNode < ApplicationRecord
       },
     }
 
-  delegate :to_apply, to: :text_section_node_contained_content, allow_nil: true, prefix: :contained_content
-
   def node
     node_extra.with_indifferent_access.merge(
       slice(:node_type, :tag, :node_uuid, :text_digest, :content).compact

api/app/models/text_section_node_link.rb

@@ -4,8 +4,8 @@
 class TextSectionNodeLink < ApplicationRecord
   include View
 
-  belongs_to_readonly :parent, class_name: "TextSectionNode", inverse_of: :text_section_node_links
-  belongs_to_readonly :child, class_name: "TextSectionNode", inverse_of: :ancestor_links
+  belongs_to_readonly :parent, class_name: "TextSectionNode", inverse_of: :text_section_node_links, primary_key: %i[text_section_id id], foreign_key: %i[text_section_id parent_id]
+  belongs_to_readonly :child, class_name: "TextSectionNode", inverse_of: :ancestor_links, primary_key: %i[text_section_id id], foreign_key: %i[text_section_id child_id]
 
   scope :in_order, -> { order(child_depth: :asc, child_node_index: :asc) }
   scope :in_reverse_order, -> { order(parent_depth: :desc, parent_node_index: :desc) }

api/db/migrate/20251121202033_update_text_section_node_links_to_version_2.rb

@@ -0,0 +1,6 @@
+class UpdateTextSectionNodeLinksToVersion2 < ActiveRecord::Migration[7.0]
+  def change
+  
+    update_view :text_section_node_links, version: 2, revert_to_version: 1
+  end
+end

api/db/structure.sql

@@ -2977,14 +2977,15 @@ CREATE VIEW public.text_section_aggregations AS
 --
 
 CREATE VIEW public.text_section_node_links AS
- SELECT parent.id AS parent_id,
+ SELECT parent.text_section_id,
+    parent.id AS parent_id,
     child.id AS child_id,
     parent.depth AS parent_depth,
     parent.node_index AS parent_node_index,
     child.depth AS child_depth,
     child.node_index AS child_node_index
    FROM (public.text_section_nodes parent
-     JOIN public.text_section_nodes child ON (((parent.node_path OPERATOR(public.@>) child.node_path) AND (child.depth > parent.depth))));
+     JOIN public.text_section_nodes child ON (((parent.text_section_id = child.text_section_id) AND (parent.node_path OPERATOR(public.@>) child.node_path) AND (child.depth > parent.depth))));
 
 
 --
@@ -7840,6 +7841,7 @@ INSERT INTO "schema_migrations" (version) VALUES
 ('20251103175506'),
 ('20251103175949'),
 ('20251103180007'),
-('20251105165521');
+('20251105165521'),
+('20251121202033');
 
 

api/db/views/text_section_node_links_v02.sql

@@ -0,0 +1,10 @@
+SELECT
+  parent.text_section_id,
+  parent.id AS parent_id,
+  child.id AS child_id,
+  parent.depth AS parent_depth,
+  parent.node_index AS parent_node_index,
+  child.depth AS child_depth,
+  child.node_index AS child_node_index
+  FROM text_section_nodes parent
+  INNER JOIN text_section_nodes child ON parent.text_section_id = child.text_section_id AND parent.node_path @> child.node_path AND child.depth > parent.depth