Skip to content

Commit f42aafe

Browse files
committed
[E] Switch login link to overlay button on resource detail
1 parent a94da09 commit f42aafe

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

client/src/frontend/components/resource/Detail/index.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
11
import PropTypes from "prop-types";
22
import { Trans, useTranslation } from "react-i18next";
3-
import { Link } from "react-router-dom";
3+
import { useDispatch } from "react-redux";
44
import CommentContainer from "global/containers/comment";
55
import IconComposer from "global/components/utility/IconComposer";
6-
import lh from "helpers/linkHandler";
76
import Hero from "../Hero";
87
import LinkComponent from "../Link";
98
import Meta from "../Meta";
109
import Title from "../Title";
1110
import VariantList from "../VariantList";
1211
import Share from "../Share";
1312
import Annotations from "./Annotations";
13+
import { uiVisibilityActions } from "actions";
1414
import * as Styled from "./styles";
1515
import * as StyledLink from "../Link/styles";
1616

1717
export default function ResourceDetail({ resource, projectTitle }) {
1818
const { t } = useTranslation();
19+
const dispatch = useDispatch();
1920

2021
if (!resource) return null;
2122

@@ -27,6 +28,9 @@ export default function ResourceDetail({ resource, projectTitle }) {
2728
? `${attr.title} | ${projectTitle}`
2829
: attr.title;
2930

31+
const onLoginClick = () =>
32+
dispatch(uiVisibilityActions.visibilityShow("signInUpOverlay"));
33+
3034
return (
3135
<Styled.Container>
3236
<Styled.Grid>
@@ -72,7 +76,9 @@ export default function ResourceDetail({ resource, projectTitle }) {
7276
<Styled.EmptyMessage>
7377
<Trans
7478
i18nKey="placeholders.comments.unauthenticated_full"
75-
components={[<Link to={lh.link("frontendLogin")} />]}
79+
components={[
80+
<Styled.LoginButton type="button" onClick={onLoginClick} />
81+
]}
7682
/>
7783
</Styled.EmptyMessage>
7884
)}

client/src/frontend/components/resource/Detail/styles.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,3 +208,8 @@ export const EmptyMessage = styled.p`
208208
padding-block: 30px;
209209
font-family: var(--font-family-heading);
210210
`;
211+
212+
export const LoginButton = styled.button`
213+
${buttonUnstyled}
214+
text-decoration: underline;
215+
`;

0 commit comments

Comments
 (0)