Add type annotations to text_mobject.py (#4381)

Co-authored-by: Benjamin Hackl <[email protected]>

Author: henrikmidtiby

manim/mobject/mobject.py

@@ -2357,7 +2357,7 @@ def __getitem__(self, value):
     def __iter__(self):
         return iter(self.split())
 
-    def __len__(self):
+    def __len__(self) -> int:
         return len(self.split())
 
     def get_group_class(self) -> type[Group]:

manim/mobject/svg/svg_mobject.py

@@ -11,7 +11,7 @@
 import svgelements as se
 
 from manim import config, logger
-from manim.utils.color import ParsableManimColor
+from manim.utils.color import ManimColor, ParsableManimColor
 
 from ...constants import RIGHT
 from ...utils.bezier import get_quadratic_approximation_of_cubic
@@ -120,7 +120,7 @@ def __init__(
         self.should_center = should_center
         self.svg_height = height
         self.svg_width = width
-        self.color = color
+        self.color = ManimColor(color)
         self.opacity = opacity
         self.fill_color = fill_color
         self.fill_opacity = fill_opacity  # type: ignore[assignment]

manim/mobject/text/code_mobject.py

@@ -19,7 +19,6 @@
 from manim.mobject.geometry.arc import Dot
 from manim.mobject.geometry.shape_matchers import SurroundingRectangle
 from manim.mobject.opengl.opengl_compatibility import ConvertToOpenGL
-from manim.mobject.text.text_mobject import Paragraph
 from manim.mobject.types.vectorized_mobject import VGroup, VMobject
 from manim.typing import StrPath
 from manim.utils.color import WHITE, ManimColor
@@ -119,6 +118,7 @@ def construct(self):
         "line_spacing": 0.5,
         "disable_ligatures": True,
     }
+    code: VMobject
 
     def __init__(
         self,
@@ -200,6 +200,8 @@ def __init__(
         base_paragraph_config = self.default_paragraph_config.copy()
         base_paragraph_config.update(paragraph_config)
 
+        from manim.mobject.text.text_mobject import Paragraph
+
         self.code_lines = Paragraph(
             *code_lines,
             **base_paragraph_config,

manim/mobject/text/numbers.py

@@ -18,7 +18,7 @@
 from manim.mobject.value_tracker import ValueTracker
 from manim.typing import Vector3DLike
 
-string_to_mob_map: dict[str, VMobject] = {}
+string_to_mob_map: dict[str, SingleStringMathTex] = {}
 
 
 class DecimalNumber(VMobject, metaclass=ConvertToOpenGL):
@@ -227,7 +227,7 @@ def _string_to_mob(
         if string not in string_to_mob_map:
             string_to_mob_map[string] = mob_class(string, **kwargs)
         mob = string_to_mob_map[string].copy()
-        mob.font_size = self._font_size  # type: ignore[attr-defined]
+        mob.font_size = self._font_size
         return mob
 
     def _get_formatter(self, **kwargs: Any) -> str:

manim/mobject/text/tex_mobject.py

@@ -259,7 +259,7 @@ def __init__(
         *tex_strings: str,
         arg_separator: str = " ",
         substrings_to_isolate: Iterable[str] | None = None,
-        tex_to_color_map: dict[str, ManimColor] | None = None,
+        tex_to_color_map: dict[str, ParsableManimColor] | None = None,
         tex_environment: str | None = "align*",
         **kwargs: Any,
     ):
@@ -269,7 +269,7 @@ def __init__(
             [] if substrings_to_isolate is None else substrings_to_isolate
         )
         if tex_to_color_map is None:
-            self.tex_to_color_map: dict[str, ManimColor] = {}
+            self.tex_to_color_map: dict[str, ParsableManimColor] = {}
         else:
             self.tex_to_color_map = tex_to_color_map
         self.tex_environment = tex_environment
@@ -416,17 +416,17 @@ def set_opacity_by_tex(
         return self
 
     def set_color_by_tex_to_color_map(
-        self, texs_to_color_map: dict[str, ManimColor], **kwargs: Any
+        self, texs_to_color_map: dict[str, ParsableManimColor], **kwargs: Any
     ) -> Self:
         for texs, color in list(texs_to_color_map.items()):
             try:
                 # If the given key behaves like tex_strings
                 texs + ""
-                self.set_color_by_tex(texs, color, **kwargs)
+                self.set_color_by_tex(texs, ManimColor(color), **kwargs)
             except TypeError:
                 # If the given key is a tuple
                 for tex in texs:
-                    self.set_color_by_tex(tex, color, **kwargs)
+                    self.set_color_by_tex(tex, ManimColor(color), **kwargs)
         return self
 
     def index_of_part(self, part: MathTex) -> int:
@@ -508,7 +508,9 @@ def __init__(
         self.tex_environment = tex_environment
         line_separated_items = [s + "\\\\" for s in items]
         super().__init__(
-            *line_separated_items, tex_environment=tex_environment, **kwargs
+            *line_separated_items,
+            tex_environment=tex_environment,
+            **kwargs,
         )
         for part in self:
             dot = MathTex("\\cdot").scale(self.dot_scale_factor)
@@ -519,9 +521,13 @@ def __init__(
     def fade_all_but(self, index_or_string: int | str, opacity: float = 0.5) -> None:
         arg = index_or_string
         if isinstance(arg, str):
-            part = self.get_part_by_tex(arg)
+            part: VGroup | VMobject | None = self.get_part_by_tex(arg)
+            if part is None:
+                raise Exception(
+                    f"Could not locate part by provided tex string '{arg}'."
+                )
         elif isinstance(arg, int):
-            part = self.submobjects[arg]  # type: ignore[assignment]
+            part = self.submobjects[arg]
         else:
             raise TypeError(f"Expected int or string, got {arg}")
         for other_part in self.submobjects: