Skip to content

Commit 053e400

Browse files
cobordismAron Fischernaveen521kk
authored
Remove Carriage Return (#1281)
Co-authored-by: Aron Fischer <cobordism@github, co-bordism@gitlab> Co-authored-by: Naveen M K <[email protected]>
1 parent 5b2d5c3 commit 053e400

File tree

6 files changed

+226
-226
lines changed

6 files changed

+226
-226
lines changed

docs/source/changelog/0.5.0-changelog.rst

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ Deprecated classes and functions
7676
--------------------------------
7777

7878
* `#1124 <https://github.com/ManimCommunity/manim/pull/1124>`__: Deprecated :class:`ShowCreation` in favor of :class:`Create`
79-
1. Deprecated :class:`ShowCreation` in favor of :class:`Create` across the library with the exception of the `show_creation` boolean variable `vector_space_scene.py`
79+
1. Deprecated :class:`ShowCreation` in favor of :class:`Create` across the library with the exception of the `show_creation` boolean variable `vector_space_scene.py`
8080
2. Added a deprecation warning in the original :class:`ShowCreation` class.
8181

8282
* `#1110 <https://github.com/ManimCommunity/manim/pull/1110>`__: Deprecated SmallDot + OpenGLSmallDot
@@ -86,8 +86,8 @@ New features
8686
------------
8787

8888
* `#1037 <https://github.com/ManimCommunity/manim/pull/1037>`__: Added new fade and transform animations (:class:`~.TransformMatchingShapes`, :class:`~.TransformMatchingTex`, :class:`~.FadeTransform`) from 3b1b/manim
89-
Added new Fade animation: :class:`~FadeOutToPoint`
90-
Added :class:`~FadeTransform` and :class:`~FadeTransformPieces` for transforming mobjects and submobjects with a fade
89+
Added new Fade animation: :class:`~FadeOutToPoint`
90+
Added :class:`~FadeTransform` and :class:`~FadeTransformPieces` for transforming mobjects and submobjects with a fade
9191
Added :class:`~TransformMatchingShapes` and :class:`~TransformMatchingTex` for transforming mobjects and tex that have matching parts
9292

9393
* `#1097 <https://github.com/ManimCommunity/manim/pull/1097>`__: Added 3D Mobject :class:`~.Dot3D`
@@ -109,8 +109,8 @@ Enhancements
109109

110110

111111
* `#1157 <https://github.com/ManimCommunity/manim/pull/1157>`__: Refresh triangulation on call to :meth:`~.OpenGLVMobject.apply_points_function`
112-
Rotate called apply_points_function, which was previous not subclassed by OpenGLMobject - now it is. Then, the vertex normals can be updated too.
113-
112+
Rotate called apply_points_function, which was previous not subclassed by OpenGLMobject - now it is. Then, the vertex normals can be updated too.
113+
114114
Additionally, the old_points matrix would change after rotating, making the old points / new points test irrelevant. This is addressed with a .copy call.
115115

116116
* `#1151 <https://github.com/ManimCommunity/manim/pull/1151>`__: Added parametric function support to :class:`OpenGLSurface`
@@ -123,12 +123,12 @@ Enhancements
123123
OpenGL play logic has been improved to support caching and skipping with `-n` argument ( it is now similar to Cairo play logic). A random bug was fixed in OpenGLSurface and OpenGL background color can now be changed via `background_color` argument.
124124

125125
* `#1118 <https://github.com/ManimCommunity/manim/pull/1118>`__: Allow passing animation arguments with .animate syntax
126-
Users will now be able to do things like `obj.animate(run_time=2).method(arg)` if they want to specify animation arguments for an individual `.animate` call, and can still not specify any arguments like `obj.animate.method(arg)`.
127-
126+
Users will now be able to do things like `obj.animate(run_time=2).method(arg)` if they want to specify animation arguments for an individual `.animate` call, and can still not specify any arguments like `obj.animate.method(arg)`.
127+
128128
Passing animation arguments is only allowed directly after `.animate` is accessed, if passed elsewhere then a `ValueError` is raised.
129129

130130
* `#718 <https://github.com/ManimCommunity/manim/pull/718>`__: Rotating the numbers in y axis
131-
In Axes, the y axis will be rotated 90deg but the numbers are
131+
In Axes, the y axis will be rotated 90deg but the numbers are
132132
also rotated and shouldn't be. Fixes this issue.
133133

134134
* `#1070 <https://github.com/ManimCommunity/manim/pull/1070>`__: Raise FileNotFoundError when unable to locate the .cfg file specified via ``--config_file``
@@ -165,9 +165,9 @@ Fixed bugs
165165
Fixed undefined variables and converted :class:`Mobject` to :class:`OpenGLMobject`. Also, fixed assert statement in :class:`ApplyMethod`.
166166

167167
* `#1092 <https://github.com/ManimCommunity/manim/pull/1092>`__: Refactored coordinate_systems.py, fixed bugs, added :class:`~.NumberPlane` test
168-
The default behavior of :meth:`~.Mobject.rotate` is to rotate about the center of :class:`~.Mobject`. :class:`~.NumberLine` is symmetric about the point at the number 0 only when ``|x_min|`` == ``|x_max|``. Ideally, the rotation should coincide with
169-
the point at number 0 on the line.
170-
168+
The default behavior of :meth:`~.Mobject.rotate` is to rotate about the center of :class:`~.Mobject`. :class:`~.NumberLine` is symmetric about the point at the number 0 only when ``|x_min|`` == ``|x_max|``. Ideally, the rotation should coincide with
169+
the point at number 0 on the line.
170+
171171
Added a regression test and additionally fixed some bugs introduced in :pr:`718`.
172172

173173
* `#1078 <https://github.com/ManimCommunity/manim/pull/1078>`__: Removed stray print statements from `__main__.py`
@@ -276,8 +276,8 @@ Changes to our development infrastructure
276276

277277

278278
* `#1071 <https://github.com/ManimCommunity/manim/pull/1071>`__: Enable pytest-cov based code coverage
279-
- Include pytest-cov as a python module as part of developer dependencies
280-
- In updating poetry to include pytest-cov, manimpango moved from version 0.2.3 to 0.2.4, and libpango1.0-dev needed to be installed in Ubuntu.
279+
- Include pytest-cov as a python module as part of developer dependencies
280+
- In updating poetry to include pytest-cov, manimpango moved from version 0.2.3 to 0.2.4, and libpango1.0-dev needed to be installed in Ubuntu.
281281
- Add to the CI workflow (`ci.yml`) to create and upload test coverage.
282282

283283
* `#1073 <https://github.com/ManimCommunity/manim/pull/1073>`__: Removed "one line summary" from PULL_REQUEST_TEMPLATE.md
@@ -296,12 +296,12 @@ Code quality improvements and similar refactors
296296

297297

298298
* `#1019 <https://github.com/ManimCommunity/manim/pull/1019>`__: Refactored :meth:`~.Scene.play`
299-
- Removed the _**three**_ decorators of :meth:`~.Scene.play`, in particular: caching logic and file writer logic are now included within :meth:`~.Scene.play` (it wasn't possible before, because `scene.wait` and `scene.play` were two different things).
300-
- Added `is_static_wait` attributes to Wait. (<=> if wait is a frozen frame).
301-
- Renamed and moved `scene.add_static_frame` to `renderer.freeze_current_frame`.
302-
- Now when calling play without animation, it raises `ValueError` instead of just a warning.
303-
- Fixed :pr:`874` by modfying `renderer.update_skipping_status`
304-
- `renderer` starts the animation with `scene.begin_animations` (`scene.compile_animation_data` used to do this)
305-
- The run time and the time progression generation is now done in `scene.play_internal` although it'd make more sense that renderer processes it later.
299+
- Removed the _**three**_ decorators of :meth:`~.Scene.play`, in particular: caching logic and file writer logic are now included within :meth:`~.Scene.play` (it wasn't possible before, because `scene.wait` and `scene.play` were two different things).
300+
- Added `is_static_wait` attributes to Wait. (<=> if wait is a frozen frame).
301+
- Renamed and moved `scene.add_static_frame` to `renderer.freeze_current_frame`.
302+
- Now when calling play without animation, it raises `ValueError` instead of just a warning.
303+
- Fixed :pr:`874` by modfying `renderer.update_skipping_status`
304+
- `renderer` starts the animation with `scene.begin_animations` (`scene.compile_animation_data` used to do this)
305+
- The run time and the time progression generation is now done in `scene.play_internal` although it'd make more sense that renderer processes it later.
306306
- Added a bunch of cool tests thanks to mocks, and thanks to the new syntax `scene.render`
307307

docs/source/contributing/reference/manim_directive.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
manim\_directive
1+
manim\_directive
22
================
33

44
.. currentmodule:: manim_directive
Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
1-
import click
2-
from cloup import option, option_group
3-
4-
ease_of_access_options = option_group(
5-
"Ease of access options",
6-
option(
7-
"--progress_bar",
8-
default="display",
9-
show_default=True,
10-
type=click.Choice(
11-
["display", "leave", "none"],
12-
case_sensitive=False,
13-
),
14-
help="Display progress bars and/or keep them displayed.",
15-
),
16-
option(
17-
"-p",
18-
"--preview",
19-
is_flag=True,
20-
help="Preview the Scene's animation. OpenGL does a live preview in a "
21-
"popup window. Cairo opens the rendered video file in the system "
22-
"default media player.",
23-
),
24-
option(
25-
"-f",
26-
"--show_in_file_browser",
27-
is_flag=True,
28-
help="Show the output file in the file browser.",
29-
),
30-
option("--jupyter", is_flag=True, help="Using jupyter notebook magic."),
31-
)
1+
import click
2+
from cloup import option, option_group
3+
4+
ease_of_access_options = option_group(
5+
"Ease of access options",
6+
option(
7+
"--progress_bar",
8+
default="display",
9+
show_default=True,
10+
type=click.Choice(
11+
["display", "leave", "none"],
12+
case_sensitive=False,
13+
),
14+
help="Display progress bars and/or keep them displayed.",
15+
),
16+
option(
17+
"-p",
18+
"--preview",
19+
is_flag=True,
20+
help="Preview the Scene's animation. OpenGL does a live preview in a "
21+
"popup window. Cairo opens the rendered video file in the system "
22+
"default media player.",
23+
),
24+
option(
25+
"-f",
26+
"--show_in_file_browser",
27+
is_flag=True,
28+
help="Show the output file in the file browser.",
29+
),
30+
option("--jupyter", is_flag=True, help="Using jupyter notebook magic."),
31+
)

manim/cli/render/global_options.py

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,33 @@
1-
import click
2-
from cloup import option, option_group
3-
4-
global_options = option_group(
5-
"Global options",
6-
option(
7-
"-c",
8-
"--config_file",
9-
help="Specify the configuration file to use for render settings.",
10-
),
11-
option(
12-
"--custom_folders",
13-
is_flag=True,
14-
help="Use the folders defined in the [custom_folders] section of the "
15-
"config file to define the output folder structure.",
16-
),
17-
option(
18-
"--disable_caching",
19-
is_flag=True,
20-
help="Disable the use of the cache (still generates cache files).",
21-
),
22-
option("--flush_cache", is_flag=True, help="Remove cached partial movie files."),
23-
option("--tex_template", help="Specify a custom TeX template file."),
24-
option(
25-
"-v",
26-
"--verbosity",
27-
type=click.Choice(
28-
["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"],
29-
case_sensitive=False,
30-
),
31-
help="Verbosity of CLI output. Changes ffmpeg log level unless 5+.",
32-
),
33-
)
1+
import click
2+
from cloup import option, option_group
3+
4+
global_options = option_group(
5+
"Global options",
6+
option(
7+
"-c",
8+
"--config_file",
9+
help="Specify the configuration file to use for render settings.",
10+
),
11+
option(
12+
"--custom_folders",
13+
is_flag=True,
14+
help="Use the folders defined in the [custom_folders] section of the "
15+
"config file to define the output folder structure.",
16+
),
17+
option(
18+
"--disable_caching",
19+
is_flag=True,
20+
help="Disable the use of the cache (still generates cache files).",
21+
),
22+
option("--flush_cache", is_flag=True, help="Remove cached partial movie files."),
23+
option("--tex_template", help="Specify a custom TeX template file."),
24+
option(
25+
"-v",
26+
"--verbosity",
27+
type=click.Choice(
28+
["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"],
29+
case_sensitive=False,
30+
),
31+
help="Verbosity of CLI output. Changes ffmpeg log level unless 5+.",
32+
),
33+
)

manim/cli/render/output_options.py

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
1-
import click
2-
from cloup import option, option_group
3-
4-
output_options = option_group(
5-
"Output options",
6-
option(
7-
"-o",
8-
"--output_file",
9-
multiple=True,
10-
help="Specify the filename(s) of the rendered scene(s).",
11-
),
12-
option(
13-
"--write_to_movie",
14-
is_flag=True,
15-
default=None,
16-
help="Write to a file.",
17-
),
18-
option(
19-
"--media_dir",
20-
type=click.Path(),
21-
help="Path to store rendered videos and latex.",
22-
),
23-
option("--log_dir", type=click.Path(), help="Path to store render logs."),
24-
option(
25-
"--log_to_file",
26-
is_flag=True,
27-
help="Log terminal output to file.",
28-
),
29-
)
1+
import click
2+
from cloup import option, option_group
3+
4+
output_options = option_group(
5+
"Output options",
6+
option(
7+
"-o",
8+
"--output_file",
9+
multiple=True,
10+
help="Specify the filename(s) of the rendered scene(s).",
11+
),
12+
option(
13+
"--write_to_movie",
14+
is_flag=True,
15+
default=None,
16+
help="Write to a file.",
17+
),
18+
option(
19+
"--media_dir",
20+
type=click.Path(),
21+
help="Path to store rendered videos and latex.",
22+
),
23+
option("--log_dir", type=click.Path(), help="Path to store render logs."),
24+
option(
25+
"--log_to_file",
26+
is_flag=True,
27+
help="Log terminal output to file.",
28+
),
29+
)

0 commit comments

Comments
 (0)