Codeql (#3084)

* Add CodeQL workflow for GitHub code scanning

* fix codeql errors

* ignore example scenes and tests

Co-authored-by: LGTM Migrator <[email protected]>
Co-authored-by: Naveen M K <[email protected]>

Author: 3 people

.github/codeql.yml

@@ -0,0 +1,17 @@
+query-filters:
+    - exclude:
+          id: py/init-calls-subclass
+    - exclude:
+          id: py/unexpected-raise-in-special-method
+    - exclude:
+          id: py/modification-of-locals
+    - exclude:
+          id: py/multiple-calls-to-init
+    - exclude:
+          id: py/missing-call-to-init
+
+paths:
+    - manim
+paths-ignore:
+    - tests/
+    - example_scenes/

.github/workflows/codeql.yml

@@ -0,0 +1,42 @@
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+  schedule:
+    - cron: "21 16 * * 3"
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ python ]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: ${{ matrix.language }}
+          config-file: ./.github/codeql.yml
+          queries: +security-and-quality
+
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v2
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2
+        with:
+          category: "/language:${{ matrix.language }}"

manim/mobject/graph.py

@@ -627,13 +627,11 @@ def _create_vertex(
                 f"Vertex identifier '{vertex}' is already used for a vertex in this graph.",
             )
 
-        if isinstance(label, (Mobject, OpenGLMobject)):
-            label = label
-        elif label is True:
+        if label is True:
             label = MathTex(vertex, fill_color=label_fill_color)
         elif vertex in self._labels:
             label = self._labels[vertex]
-        else:
+        elif not isinstance(label, (Mobject, OpenGLMobject)):
             label = None
 
         base_vertex_config = copy(self.default_vertex_config)

manim/mobject/text/text_mobject.py

@@ -92,7 +92,7 @@ def remove_invisible_chars(mobject: SVGMobject) -> SVGMobject:
     :class:`~.SVGMobject`
         The SVGMobject without unwanted invisible characters.
     """
-
+    # TODO: Refactor needed
     iscode = False
     if mobject.__class__.__name__ == "Text":
         mobject = mobject[:]

manim/mobject/three_d/three_dimensions.py

@@ -124,12 +124,15 @@ def __init__(
         self.pre_function_handle_to_anchor_scale_factor = (
             pre_function_handle_to_anchor_scale_factor
         )
-        self.func = func
+        self._func = func
         self._setup_in_uv_space()
         self.apply_function(lambda p: func(p[0], p[1]))
         if self.should_make_jagged:
             self.make_jagged()
 
+    def func(self, u: float, v: float):
+        return self._func(u, v)
+
     def _get_u_values_and_v_values(self):
         res = tuplify(self.resolution)
         if len(res) == 1:
@@ -371,6 +374,8 @@ def __init__(
             res_value = (101, 51)
         elif config.renderer == RendererType.CAIRO:
             res_value = (24, 12)
+        else:
+            raise Exception("Unknown renderer")
 
         resolution = resolution if resolution is not None else res_value