Improve Axes: rotate labels of y-axis (#718)

* Rotating the numbers in y axis

I don't know why people haven't fixed this issue.
In Axes, the y axis will be rotated 90deg.
But the numbers are also rotated.
to fix it i rotated numbers in y axis -90deg

* Update coordinate_systems.py

* Added missing 'self'

* optimized code

* Added code for rotating numbers in y-axis

* Update graph_scene.py

* Update graph_scene.py

* removed code for testing

* Update graph_scene.py

* propose alternative approach for rotating labels of axes

* unify behavior of Axes and GraphScene: add labels in Axes only after rotation

* Update number_line.py

Updated file to property access fix on master

Co-authored-by: Benjamin Hackl <[email protected]>
Co-authored-by: Jason Villanueva <[email protected]>

Author: 3 people

manim/mobject/coordinate_systems.py

@@ -134,7 +134,7 @@ def __init__(
         self,
         axis_config=None,
         x_axis_config=None,
-        y_axis_config={"label_direction": LEFT},
+        y_axis_config=None,
         center_point=ORIGIN,
         **kwargs
     ):
@@ -144,6 +144,8 @@ def __init__(
                 "include_tip": True,
                 "exclude_zero_from_default_numbers": True,
             }
+        if y_axis_config is None:
+            y_axis_config = {"label_direction": LEFT, "rotation": 90 * DEGREES}
         self.axis_config = axis_config
         if x_axis_config is None:
             x_axis_config = {}
@@ -154,7 +156,6 @@ def __init__(
         VGroup.__init__(self, **kwargs)
         self.x_axis = self.create_axis(self.x_min, self.x_max, self.x_axis_config)
         self.y_axis = self.create_axis(self.y_min, self.y_max, self.y_axis_config)
-        self.y_axis.rotate(90 * DEGREES, about_point=ORIGIN)
         # Add as a separate group in case various other
         # mobjects are added to self, as for example in
         # NumberPlane below

manim/mobject/number_line.py

@@ -24,6 +24,7 @@ def __init__(
         color=LIGHT_GREY,
         unit_size=1,
         width=None,
+        rotation=0,
         include_ticks=True,
         tick_size=0.1,
         tick_frequency=1,
@@ -53,6 +54,7 @@ def __init__(
         self.unit_size = unit_size
         self.include_ticks = include_ticks
         self.tick_size = tick_size
+        self.rotation = rotation
         self.tick_frequency = tick_frequency
         self.leftmost_tick = leftmost_tick
         self.numbers_with_elongated_ticks = numbers_with_elongated_ticks
@@ -92,6 +94,7 @@ def __init__(
             self.add_tip()
         if self.include_ticks:
             self.add_tick_marks()
+        self.rotate(self.rotation)
         if self.include_numbers:
             self.add_numbers()
 
@@ -186,7 +189,12 @@ def default_numbers_to_display(self):
         return numbers
 
     def get_number_mobject(
-        self, number, number_config=None, scale_val=None, direction=None, buff=None
+        self,
+        number,
+        number_config=None,
+        scale_val=None,
+        direction=None,
+        buff=None,
     ):
         number_config = merge_dicts_recursively(
             self.decimal_number_config,

manim/scene/graph_scene.py

@@ -104,8 +104,8 @@ def __init__(
         y_axis_visibility=True,  # show or hide the y axis
         x_label_position=UP + RIGHT,  # where to place the label of the x axis
         y_label_position=UP + RIGHT,  # where to place the label of the y axis
-        x_axis_config={},
-        y_axis_config={},
+        x_axis_config=None,
+        y_axis_config=None,
         **kwargs,
     ):
         self.x_min = x_min
@@ -135,8 +135,8 @@ def __init__(
         self.y_axis_visibility = y_axis_visibility
         self.x_label_position = x_label_position
         self.y_label_position = y_label_position
-        self.x_axis_config = x_axis_config
-        self.y_axis_config = y_axis_config
+        self.x_axis_config = {} if x_axis_config is None else x_axis_config
+        self.y_axis_config = {} if y_axis_config is None else y_axis_config
         super().__init__(**kwargs)
 
     def setup(self):
@@ -232,6 +232,7 @@ def setup_axes(self, animate=False):
         )
         y_axis.shift(self.graph_origin - y_shift)
         y_axis.rotate(np.pi / 2, about_point=self.graph_origin)
+
         if len(self.y_labeled_nums) > 0:
             if self.exclude_zero_label:
                 self.y_labeled_nums = [y for y in self.y_labeled_nums if y != 0]