Skip to content

Commit b3df1cf

Browse files
authored
Properly define init_points methods (#4360)
1 parent cb8af6f commit b3df1cf

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

manim/mobject/geometry/arc.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -916,7 +916,8 @@ def generate_points(self) -> None:
916916
self.append_points(outer_arc.points)
917917
self.add_line_to(inner_arc.points[0])
918918

919-
init_points = generate_points
919+
def init_points(self) -> None:
920+
self.generate_points()
920921

921922

922923
class Sector(AnnularSector):
@@ -990,7 +991,8 @@ def generate_points(self) -> None:
990991
self.append_points(inner_circle.points)
991992
self.shift(self.arc_center)
992993

993-
init_points = generate_points
994+
def init_points(self) -> None:
995+
self.generate_points()
994996

995997

996998
class CubicBezier(VMobject, metaclass=ConvertToOpenGL):

manim/mobject/geometry/line.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,8 @@ def set_points_by_ends(
147147

148148
self._account_for_buff(buff)
149149

150-
init_points = generate_points
150+
def init_points(self) -> None:
151+
self.generate_points()
151152

152153
def _account_for_buff(self, buff: float) -> None:
153154
if buff <= 0:

manim/mobject/graphing/functions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,8 @@ def generate_points(self) -> Self:
182182
self.make_smooth()
183183
return self
184184

185-
init_points = generate_points
185+
def init_points(self) -> None:
186+
self.generate_points()
186187

187188

188189
class FunctionGraph(ParametricFunction):
@@ -328,4 +329,5 @@ def generate_points(self) -> Self:
328329
self.make_smooth()
329330
return self
330331

331-
init_points = generate_points
332+
def init_points(self) -> None:
333+
self.generate_points()

manim/mobject/svg/svg_mobject.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,7 @@ def __init__(
496496

497497
super().__init__(**kwargs)
498498

499-
def init_points(self) -> None:
499+
def generate_points(self) -> None:
500500
# TODO: cache mobject in a re-importable way
501501

502502
self.handle_commands()
@@ -509,7 +509,8 @@ def init_points(self) -> None:
509509
# Get rid of any null curves
510510
self.set_points(self.get_points_without_null_curves())
511511

512-
generate_points = init_points
512+
def init_points(self) -> None:
513+
self.generate_points()
513514

514515
def handle_commands(self) -> None:
515516
all_points: list[np.ndarray] = []

0 commit comments

Comments
 (0)