Commit ce1fff6
Improve line rendering performance by decreasing redundant subdivision count (#3893)
* Reduce line cylinder height resolution to 2
Subdividing a line cylinder by its height adds no extra resolution -
since it's not checkerboarded, all new rectangles would look the same as
one long rectangle. Decreasing the default subdivision resolution to 2
reduces submobject count by 12x while sacrificing no quality.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Allow for 2 resolution values in Line3D
This prevents a breaking change where a tuple of resolution values
passed to Line3D.resolution would no longer work.
Also applies to Arrow3D.
* Assign field before init
* Add checkered line info to docstring
* Regenerate test control frame
* Regenerate missing control frames
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Francisco Manríquez Novoa <[email protected]>1 parent fc58a46 commit ce1fff6
File tree
17 files changed
+18
-1
lines changed- manim/mobject/three_d
- tests/test_graphical_units/control_data/threed
17 files changed
+18
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
895 | 895 | | |
896 | 896 | | |
897 | 897 | | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
898 | 904 | | |
899 | 905 | | |
900 | 906 | | |
| |||
915 | 921 | | |
916 | 922 | | |
917 | 923 | | |
| 924 | + | |
918 | 925 | | |
919 | 926 | | |
920 | 927 | | |
| 928 | + | |
921 | 929 | | |
922 | 930 | | |
923 | 931 | | |
| |||
951 | 959 | | |
952 | 960 | | |
953 | 961 | | |
| 962 | + | |
954 | 963 | | |
955 | 964 | | |
956 | 965 | | |
| |||
1122 | 1131 | | |
1123 | 1132 | | |
1124 | 1133 | | |
| 1134 | + | |
| 1135 | + | |
1125 | 1136 | | |
1126 | 1137 | | |
1127 | 1138 | | |
| |||
1148 | 1159 | | |
1149 | 1160 | | |
1150 | 1161 | | |
| 1162 | + | |
1151 | 1163 | | |
1152 | 1164 | | |
1153 | 1165 | | |
1154 | | - | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
1155 | 1172 | | |
1156 | 1173 | | |
1157 | 1174 | | |
| |||
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
0 commit comments