Skip to content

Commit dcef407

Browse files
authored
Bugfix: make sure last frame for animations with updaters is correct (#983)
* Fix last frame issue * Add tests * black * black
1 parent a7ff7bb commit dcef407

File tree

3 files changed

+13
-0
lines changed

3 files changed

+13
-0
lines changed

manim/scene/scene.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -849,6 +849,8 @@ def play_internal(self, skip_rendering=False):
849849
for animation in self.animations:
850850
animation.finish()
851851
animation.clean_up_from_scene(self)
852+
if not self.renderer.skip_animations:
853+
self.update_mobjects(0)
852854
self.renderer.static_image = None
853855

854856
def update_to_time(self, t):
Binary file not shown.

tests/test_graphical_units/test_updaters.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,17 @@ def f(mob):
3333
self.play(ShowCreation(s))
3434

3535

36+
class LastFrameWhenClearedTest(Scene):
37+
def construct(self):
38+
dot = Dot()
39+
square = Square()
40+
square.add_updater(lambda m: m.move_to(dot, UL))
41+
self.add(square)
42+
self.play(dot.animate.shift(UP * 2), rate_func=linear)
43+
square.clear_updaters()
44+
self.wait()
45+
46+
3647
MODULE_NAME = "updaters"
3748

3849

0 commit comments

Comments
 (0)