Fix arguments of overridden set_style for BackgroundRectangle (#2658)

* Sync `set_style` arguments with base

* Minimize set_style arguments; add info log

* Remove excessive import

* more verbose logger output, added test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Benjamin Hackl <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 3 people

manim/mobject/geometry/shape_matchers.py

@@ -4,7 +4,7 @@
 
 __all__ = ["SurroundingRectangle", "BackgroundRectangle", "Cross", "Underline"]
 
-from manim import config
+from manim import config, logger
 from manim.constants import *
 from manim.mobject.geometry.line import Line
 from manim.mobject.geometry.polygram import RoundedRectangle
@@ -104,21 +104,20 @@ def pointwise_become_partial(self, mobject, a, b):
         self.set_fill(opacity=b * self.original_fill_opacity)
         return self
 
-    def set_style(
-        self,
-        stroke_color=None,
-        stroke_width=None,
-        fill_color=None,
-        fill_opacity=None,
-        family=True,
-    ):
+    def set_style(self, fill_opacity, **kwargs):
         # Unchangeable style, except for fill_opacity
+        # All other style arguments are ignored
         super().set_style(
             stroke_color=BLACK,
             stroke_width=0,
             fill_color=BLACK,
             fill_opacity=fill_opacity,
         )
+        if len(kwargs) > 0:
+            logger.info(
+                "Argument %s is ignored in BackgroundRectangle.set_style.",
+                kwargs,
+            )
         return self
 
     def get_fill_color(self):

tests/test_unit_geometry.py

@@ -1,9 +1,26 @@
 from __future__ import annotations
 
+import logging
+
 import numpy as np
 
-from manim import Sector
+logger = logging.getLogger(__name__)
+
+from manim import BackgroundRectangle, Circle, Sector
 
 
 def test_get_arc_center():
     assert np.all(Sector(arc_center=[1, 2, 0]).get_arc_center() == [1, 2, 0])
+
+
+def test_BackgroundRectangle(caplog):
+    caplog.set_level(logging.INFO)
+    c = Circle()
+    bg = BackgroundRectangle(c)
+    bg.set_style(fill_opacity=0.42)
+    assert bg.get_fill_opacity() == 0.42
+    bg.set_style(fill_opacity=1, hello="world")
+    assert (
+        "Argument {'hello': 'world'} is ignored in BackgroundRectangle.set_style."
+        in caplog.text
+    )