Skip to content

Performance: Store color data of OpenGLSurface to prevent OpenGL embed lag #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Performance: Store color data of OpenGLSurface to prevent OpenGL embed lag #3134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
844450d
store color data
icedcoffeeee Jan 23, 2023
486ad3f
Merge branch 'main' into surface-color-lag
behackl Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion manim/mobject/opengl/opengl_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,9 @@ def get_shader_data(self):
shader_data["du_point"] = du_points
shader_data["dv_point"] = dv_points
if self.colorscale:
shader_data["color"] = self._get_color_by_value(s_points)
if not hasattr(self, "color_by_val"):
self.color_by_val = self._get_color_by_value(s_points)
shader_data["color"] = self.color_by_val
else:
self.fill_in_shader_color_info(shader_data)
return shader_data
Expand Down