Skip to content

Bugfix: Fix arc start angle type #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2023
Merged

Bugfix: Fix arc start angle type #3205

merged 3 commits into from
Jul 4, 2023
+3 −3

Conversation

@AlexKempen
Copy link
Contributor

@AlexKempen AlexKempen commented Apr 6, 2023

The start_angle argument of Arc is incorrectly typed as int. Since no explicit type is assigned, and the default value is the literal 0, the implicit type is int, not float. This PR fixes this issue by adding the explicit float type.

This PR also corrects a misspelling of the word animation in the documentation of Mobject's add_animation_override.

Links to added or changed documentation pages

Arc
add_animation_override

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added functions and classes are tested

@AlexKempen AlexKempen changed the title Arc start angle type fix Bugfix: Arc start angle type fix Apr 6, 2023
@AlexKempen AlexKempen changed the title Bugfix: Arc start angle type fix Bugfix: Fix arc start angle type Apr 6, 2023
@behackl behackl added enhancement Additions and improvements in general typehints For adding/discussing typehints labels Apr 25, 2023
behackl
behackl approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks!

@behackl behackl merged commit 0d3464c into ManimCommunity:main Jul 4, 2023
@behackl behackl added this to the v0.18.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behackl behackl behackl approved these changes

Assignees

No one assigned

Labels

enhancement Additions and improvements in general typehints For adding/discussing typehints

Projects

None yet

Milestone

v0.18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexKempen @behackl