Skip to content

Bugfix: Fix arc start angle type #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Bugfix: Fix arc start angle type #3205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f97fc1
Fixed animation misspelling in Mobject's add_animation_override
AlexKempen Apr 6, 2023
1ef93cd
Corrected angle types of Arc
AlexKempen Apr 6, 2023
8da22d3
Merge branch 'main' into start-angle-type-fix
AlexKempen Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manim/mobject/geometry/arc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ def construct(self):
def __init__(
self,
radius: float = 1.0,
start_angle=0,
angle=TAU / 4,
start_angle: float = 0,
angle: float = TAU / 4,
num_components=9,
arc_center=ORIGIN,
**kwargs,
Expand Down
2 changes: 1 addition & 1 deletion manim/mobject/mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def add_animation_override(
The animation type to be overridden
override_func
The function returning an animation replacing the default animation. It gets
passed the parameters given to the animnation constructor.
passed the parameters given to the animation constructor.

Raises
------
Expand Down