Skip to content

Conversation

@Adhyyan1252
Copy link
Contributor

Overview: What does this pull request change?

Adds pkg-config to the list of needed dependencies for apple silicon.
According to https://pypi.org/project/ManimPango/ manim-pango needs pkg-config

Motivation and Explanation: Why and how do your changes improve the library?

Running into an error when executing pip3 install manim on apple silicon
Adding pkg-config resolved this issue for me.

pip3 install manim
Collecting manim
  ...
  Building wheel for manimpango (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for manimpango (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [41 lines of output]
      ....
      running build_ext
      building 'manimpango.cmanimpango' extension
      creating build/temp.macosx-13-arm64-cpython-311
      creating build/temp.macosx-13-arm64-cpython-311/private
      creating build/temp.macosx-13-arm64-cpython-311/private/var
      creating build/temp.macosx-13-arm64-cpython-311/private/var/folders
      creating build/temp.macosx-13-arm64-cpython-311/private/var/folders/6l
      creating build/temp.macosx-13-arm64-cpython-311/private/var/folders/6l/srywjz3d2rl9dm5xfxtgvy040000gn
      creating build/temp.macosx-13-arm64-cpython-311/private/var/folders/6l/srywjz3d2rl9dm5xfxtgvy040000gn/T
      creating build/temp.macosx-13-arm64-cpython-311/private/var/folders/6l/srywjz3d2rl9dm5xfxtgvy040000gn/T/pip-install-nfcb0_az
      creating build/temp.macosx-13-arm64-cpython-311/private/var/folders/6l/srywjz3d2rl9dm5xfxtgvy040000gn/T/pip-install-nfcb0_az/manimpango_0a111173a7d647f3a66a8906a30bf4e9
      creating build/temp.macosx-13-arm64-cpython-311/private/var/folders/6l/srywjz3d2rl9dm5xfxtgvy040000gn/T/pip-install-nfcb0_az/manimpango_0a111173a7d647f3a66a8906a30bf4e9/manimpango
      clang -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -I/opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.11/include/python3.11 -c /private/var/folders/6l/srywjz3d2rl9dm5xfxtgvy040000gn/T/pip-install-nfcb0_az/manimpango_0a111173a7d647f3a66a8906a30bf4e9/manimpango/cmanimpango.c -o build/temp.macosx-13-arm64-cpython-311/private/var/folders/6l/srywjz3d2rl9dm5xfxtgvy040000gn/T/pip-install-nfcb0_az/manimpango_0a111173a7d647f3a66a8906a30bf4e9/manimpango/cmanimpango.o
      /private/var/folders/6l/srywjz3d2rl9dm5xfxtgvy040000gn/T/pip-install-nfcb0_az/manimpango_0a111173a7d647f3a66a8906a30bf4e9/manimpango/cmanimpango.c:773:10: fatal error: 'cairo.h' file not found
      #include "cairo.h"
               ^~~~~~~~~
      1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for manimpango
Failed to build manimpango
ERROR: Could not build wheels for manimpango, which is required to install pyproject.toml-based projects

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the absence of pkg-config usually produces a different error compared to the one you report, installing it as a dependency does not necessarily hurt. Thanks for your contribution!

@behackl behackl merged commit e84547f into ManimCommunity:main Jul 16, 2023
@behackl behackl added this to the v0.18.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants