Skip to content

Fixed expand animation for :class:.ManimBanner #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Fixed expand animation for :class:.ManimBanner #3298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fac255e
fixed "a" appearing before shapes
behackl Jul 18, 2023
1aa2793
added animation test for ManimBanner
behackl Jul 18, 2023
fd0ffbe
added xelatex to linux pipeline
behackl Jul 18, 2023
5aa9441
xelatex -> xetex
behackl Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
uses: teatimeguest/setup-texlive-action@v2
with:
cache: true
packages: scheme-basic fontspec inputenc fontenc tipa mathrsfs calligra xcolor standalone preview doublestroke ms everysel setspace rsfs relsize ragged2e fundus-calligra microtype wasysym physics dvisvgm jknapltx wasy cm-super babel-english gnu-freefont mathastext cbfonts-fd
packages: scheme-basic fontspec inputenc fontenc tipa mathrsfs calligra xcolor standalone preview doublestroke ms everysel setspace rsfs relsize ragged2e fundus-calligra microtype wasysym physics dvisvgm jknapltx wasy cm-super babel-english gnu-freefont mathastext cbfonts-fd xetex

- name: Start virtual display (Linux)
if: runner.os == 'Linux'
Expand Down
2 changes: 1 addition & 1 deletion manim/mobject/logo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def slide_and_uncover(mob, alpha):
for letter in mob.anim:
if mob.square.get_center()[0] > letter.get_center()[0]:
letter.set_opacity(1)
self.add(letter)
self.add_to_back(letter)

# Finish animation
if alpha == 1:
Expand Down
Binary file added tests/test_graphical_units/control_data/logo/banner.npz
View file
Open in desktop
Binary file not shown.
13 changes: 13 additions & 0 deletions tests/test_graphical_units/test_banner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
from __future__ import annotations

from manim import ManimBanner
from manim.utils.testing.frames_comparison import frames_comparison

__module_test__ = "logo"


@frames_comparison(last_frame=False)
def test_banner(scene):
banner = ManimBanner()
scene.play(banner.create(), run_time=0.5)
scene.play(banner.expand(), run_time=0.5)