Skip to content

Fixed IPython terminal history and embedded shell instatiation for interactive_embed scenes #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Fixed IPython terminal history and embedded shell instatiation for interactive_embed scenes #3306

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca361c9
Fixed IPython sqlite errors/history for interactive_embed scenes
jsonvillanueva Jul 31, 2023
bc0f951
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 31, 2023
b8e39ff
Add config to instance method
jsonvillanueva Jul 31, 2023
f3b6fba
Merge branch 'main' into interactive-embed
MrDiver Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion manim/scene/scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,12 +1317,20 @@ def get_embedded_method(method_name):
# Allow for calling scene methods without prepending 'self.'.
local_namespace[method] = embedded_method

from sqlite3 import connect

from IPython.core.getipython import get_ipython
from IPython.terminal.embed import InteractiveShellEmbed
from traitlets.config import Config

cfg = Config()
cfg.TerminalInteractiveShell.confirm_exit = False
shell = InteractiveShellEmbed(config=cfg)
if get_ipython() is None:
shell = InteractiveShellEmbed.instance(config=cfg)
else:
shell = InteractiveShellEmbed(config=cfg)
hist = get_ipython().history_manager
hist.db = connect(hist.hist_file, check_same_thread=False)

keyboard_thread = threading.Thread(
target=ipython,
Expand Down