Align Ruff configuration with Impact project

- Disable preview rules to match Impact configuration
- Remove unused noqa directives (RUF100)
- Fix S404, PLW0108, PLR0917 directives that are no longer needed

Author: NicolasLafitteMM

pyproject.toml

@@ -487,7 +487,7 @@ exclude_lines = [
 ]
 
 [tool.ruff]
-preview = true
+# preview = true  # Disabled to align with Impact configuration
 line-length = 88
 respect-gitignore = true
 [tool.ruff.format]

scripts/hatch_build.py

@@ -2,7 +2,7 @@
 
 from __future__ import annotations
 
-import subprocess  # noqa: S404
+import subprocess
 from typing import Any
 
 from hatchling.builders.hooks.plugin.interface import BuildHookInterface

src/firefighter/incidents/forms/utils.py

@@ -71,7 +71,7 @@ def __init__(
 class EnumChoiceField(TypedChoiceField):
     def __init__(self, *args: Any, enum_class: type[T], **kwargs: Any) -> None:
         # Explicit for type checking
-        self.coerce_func: Callable[[Any], T] = lambda val: enum_class(  # noqa: PLW0108
+        self.coerce_func: Callable[[Any], T] = lambda val: enum_class(
             val
         )
         self.enum_class = enum_class

src/firefighter/raid/client.py

@@ -35,7 +35,7 @@ class JiraAttachmentError(Exception):
 
 
 class RaidJiraClient(JiraClient):
-    def create_issue(  # noqa: PLR0912, PLR0913, C901, PLR0917
+    def create_issue(  # noqa: PLR0912, PLR0913, C901
         self,
         issuetype: str | None,
         summary: str,

src/firefighter/raid/service.py

@@ -215,7 +215,7 @@ def create_issue_customer(
     return issue
 
 
-def create_issue_seller(  # noqa: PLR0913, PLR0917
+def create_issue_seller(  # noqa: PLR0913
     title: str,
     description: str,
     reporter: str,