-
Notifications
You must be signed in to change notification settings - Fork 48
Expand file tree
/
Copy pathCOMMIT_MESSAGE.txt
More file actions
53 lines (41 loc) · 1.41 KB
/
COMMIT_MESSAGE.txt
File metadata and controls
53 lines (41 loc) · 1.41 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
Normalize naming conventions across codebase (#204)
## Summary
Audited and normalized naming conventions to improve consistency,
readability, and contributor experience.
## Changes
### Middleware Files Renamed
- apiKeyMiddleware.js → apiKey.js
- rbacMiddleware.js → rbac.js
- idempotencyMiddleware.js → idempotency.js
Rationale: Removed redundant "Middleware" suffix to match other
middleware files (errorHandler.js, rateLimiter.js, logger.js)
### Import Updates
Updated all import statements across 10 files:
- 7 source files (routes/*)
- 3 test files
### Documentation
- Created NAMING_CONVENTIONS.md with comprehensive standards
- Created ISSUE_204_SUMMARY.md with detailed change log
## Naming Standards Established
**Files:**
- Services: PascalCase (StellarService.js)
- Models: camelCase/lowercase (apiKeys.js, transaction.js)
- Routes: lowercase (donation.js, wallet.js)
- Middleware: camelCase without suffix (apiKey.js, rbac.js)
- Utils: camelCase/lowercase (feeCalculator.js, log.js)
- Scripts: camelCase (initDB.js, manageApiKeys.js)
**Code:**
- Variables: camelCase
- Constants: UPPER_SNAKE_CASE
- Functions: camelCase
- Classes: PascalCase
- Private methods: _camelCase
## Testing
✅ All 439 tests pass
✅ No breaking changes
✅ Git history preserved with proper renames
## Acceptance Criteria
✅ Naming is consistent across the project
✅ No breaking changes introduced
✅ Documentation provided
Closes #204