Make format_with_precision thread-safe (#6)

* Add `diagham_command` to only create the command string. Also add option `wait` to `execute_diagham_script` to control whether the process should be waited for.

* format

* make format_with_precision thread-safe

* format

* fix dependency

Author: AFeuerpfeil

Project.toml

@@ -9,11 +9,13 @@ Format = "1fa38f19-a742-5d3f-a2b9-30dd87b9d5f8"
 Preferences = "21216c6a-2e73-6563-6e65-726566657250"
 Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
+ThreadSafeDicts = "4239201d-c60e-5e0a-9702-85d713665ba7"
 
 [compat]
 DelimitedFiles = "1"
 Format = "1.3.7"
 Preferences = "1.5.0"
 Printf = "1"
 SparseArrays = "1"
+ThreadSafeDicts = "0.1.6"
 julia = "1.10"

src/DiagHamInterface.jl

@@ -12,9 +12,10 @@ export write_to_txt
 export write_matrix_elements
 
 using DelimitedFiles
-using Format: cfmt
+using Format
 using SparseArrays
 using Preferences
+using ThreadSafeDicts
 
 include("utility/backup.jl")
 include("utility/diagham_path.jl")

src/utility/numbers.jl

@@ -1,11 +1,14 @@
+# Maps the format string (e.g. "%.5f") to the compiled formatter Function.
+const LOCAL_FORMAT_CACHE = ThreadSafeDict{String, Function}()
+
 """
     format_with_precision(x; atol=eps(float(T)), mode=:auto, maxdigits=20)
 
 Format number `x` as a string with absolute precision `atol`.
 Mode `:auto` uses `%f` for `[1e-3, 1e6)`, else `%e`. Use `:f` or `:e` to force format.
 """
 function format_with_precision(x::T; atol = eps(float(T)), mode::Symbol = :auto, maxdigits::Int = 20) where {T <: Real}
-    x == 0 && return "0.0"
+    iszero(x) && return "0.0"
     absx = abs(x)
     abs_atol = abs(atol)
 
@@ -16,11 +19,21 @@ function format_with_precision(x::T; atol = eps(float(T)), mode::Symbol = :auto,
         log10_atol = log10(abs_atol)
         p = ceil(Int, exp10 - log10_atol)
         p = clamp(p, 0, maxdigits)
-        return cfmt("%.$(p)e", x)
+
+        formatter = get_threadsafe_formatter("%.$(p)e")
+        return formatter(x)
     else
         p = ceil(Int, -log10(abs_atol))
         p = clamp(p, 0, maxdigits)
-        return cfmt("%.$(p)f", x)
+
+        formatter = get_threadsafe_formatter("%.$(p)f")
+        return formatter(x)
+    end
+end
+
+function get_threadsafe_formatter(fmtstr::String)
+    return get!(LOCAL_FORMAT_CACHE, fmtstr) do
+        Format.generate_formatter(fmtstr)
     end
 end