Skip to content

Commit 401e49c

Browse files
asafMasaAsaf Masa
asafMasa
and
Asaf Masa
authored
chore: fix error logs (#27)
* chore: fix error logs * chore: fix error logs --------- Co-authored-by: Asaf Masa <asafmas@users.noreply.github.com>
1 parent 49758ed commit 401e49c

File tree

8 files changed

+48
-48
lines changed

8 files changed

+48
-48
lines changed

‎src/externalServices/catalog/catalogCall.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ export class CatalogCall {
4141
logContext,
4242
});
4343
return response.data;
44-
} catch (error) {
44+
} catch (err) {
4545
this.logger.error({
4646
msg: 'Something went wrong in catalog',
4747
logContext,
48-
error,
48+
err,
4949
});
5050
throw new AppError('catalog', StatusCodes.INTERNAL_SERVER_ERROR, 'there is a problem with catalog', true);
5151
}
@@ -72,14 +72,14 @@ export class CatalogCall {
7272
response,
7373
});
7474
throw new AppError('catalog', StatusCodes.INTERNAL_SERVER_ERROR, 'Problem with the catalog during validation of productId existence', true);
75-
} catch (error) {
76-
if (error instanceof AppError) {
77-
throw error;
75+
} catch (err) {
76+
if (err instanceof AppError) {
77+
throw err;
7878
}
7979
this.logger.error({
8080
msg: 'Something went wrong in catalog',
8181
logContext,
82-
error,
82+
err,
8383
});
8484
throw new AppError('catalog', StatusCodes.INTERNAL_SERVER_ERROR, 'there is a problem with catalog', true);
8585
}

‎src/externalServices/lookupTables/lookupTablesCall.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ export class LookupTablesCall {
4545
classifications,
4646
});
4747
return classifications;
48-
} catch (error) {
48+
} catch (err) {
4949
this.logger.error({
5050
msg: 'something went wrong with lookup-tables service',
5151
logContext,
52-
error,
52+
err,
5353
});
5454
throw new AppError('lookup-tables', StatusCodes.INTERNAL_SERVER_ERROR, 'there is a problem with lookup-tables', true);
5555
}

‎src/metadata/controllers/metadataController.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ export class MetadataController {
2828
const payload = req.body;
2929
const response = await this.manager.updateMetadata(identifier, payload);
3030
return res.status(StatusCodes.OK).json(response);
31-
} catch (error) {
31+
} catch (err) {
3232
this.logger.error({
3333
msg: `Failed in updating the metadata!`,
3434
logContext,
35-
error,
35+
err,
3636
});
37-
return next(error);
37+
return next(err);
3838
}
3939
};
4040

@@ -45,13 +45,13 @@ export class MetadataController {
4545
const payload = req.body;
4646
const response = await this.manager.updateStatus(identifier, payload);
4747
return res.status(StatusCodes.OK).json(response);
48-
} catch (error) {
48+
} catch (err) {
4949
this.logger.error({
5050
msg: `Failed in changing the status!`,
5151
logContext,
52-
error,
52+
err,
5353
});
54-
return next(error);
54+
return next(err);
5555
}
5656
};
5757
}

‎src/metadata/models/metadataManager.ts‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -58,26 +58,26 @@ export class MetadataManager {
5858
logContext,
5959
modelId: identifier,
6060
});
61-
} catch (error) {
62-
if (error instanceof AppError) {
63-
throw error;
61+
} catch (err) {
62+
if (err instanceof AppError) {
63+
throw err;
6464
}
6565
this.logger.error({
6666
msg: 'unfamiliar error',
6767
logContext,
68-
error,
68+
err,
6969
});
70-
throw new AppError('error', StatusCodes.INTERNAL_SERVER_ERROR, String(error), true);
70+
throw new AppError('error', StatusCodes.INTERNAL_SERVER_ERROR, String(err), true);
7171
}
7272
try {
7373
const response = await this.catalog.patchMetadata(identifier, payload);
7474
return response;
75-
} catch (error) {
75+
} catch (err) {
7676
this.logger.error({
7777
msg: 'Error while sending to catalog service',
7878
logContext,
7979
modelId: identifier,
80-
error,
80+
err,
8181
payload,
8282
});
8383
throw new AppError('catalog', StatusCodes.INTERNAL_SERVER_ERROR, 'there is an error with catalog', true);
@@ -108,26 +108,26 @@ export class MetadataManager {
108108
logContext,
109109
modelId: identifier,
110110
});
111-
} catch (error) {
112-
if (error instanceof AppError) {
113-
throw error;
111+
} catch (err) {
112+
if (err instanceof AppError) {
113+
throw err;
114114
}
115115
this.logger.error({
116116
msg: 'unfamiliar error',
117117
logContext,
118-
error,
118+
err,
119119
});
120-
throw new AppError('error', StatusCodes.INTERNAL_SERVER_ERROR, String(error), true);
120+
throw new AppError('error', StatusCodes.INTERNAL_SERVER_ERROR, String(err), true);
121121
}
122122
try {
123123
const response = await this.catalog.changeStatus(identifier, payload);
124124
return response;
125-
} catch (error) {
125+
} catch (err) {
126126
this.logger.error({
127127
msg: 'Error while sending to catalog service',
128128
logContext,
129129
modelId: identifier,
130-
error,
130+
err,
131131
payload,
132132
});
133133
throw new AppError('catalog', StatusCodes.INTERNAL_SERVER_ERROR, 'there is an error with catalog', true);

‎src/model/controllers/modelController.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ export class ModelController {
2626
const payload = req.body;
2727
const response = await this.manager.createModel(payload);
2828
return res.status(StatusCodes.CREATED).json(response);
29-
} catch (error) {
29+
} catch (err) {
3030
this.logger.error({
3131
msg: `Failed in ingesting a new model!`,
3232
logContext,
33-
error,
33+
err,
3434
modelName: req.body.metadata.productName,
3535
});
36-
return next(error);
36+
return next(err);
3737
}
3838
};
3939

@@ -54,14 +54,14 @@ export class ModelController {
5454
validateResponse: response,
5555
});
5656
return res.status(StatusCodes.OK).json(response);
57-
} catch (error) {
57+
} catch (err) {
5858
this.logger.error({
5959
msg: `model validate failed!`,
6060
logContext,
61-
error,
61+
err,
6262
payload,
6363
});
64-
return next(error);
64+
return next(err);
6565
}
6666
};
6767
}

‎src/model/models/modelManager.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -115,17 +115,17 @@ export class ModelManager {
115115
});
116116
throw new AppError('', StatusCodes.BAD_REQUEST, validationMessage, true);
117117
}
118-
} catch (error) {
119-
if (error instanceof AppError) {
120-
throw error;
118+
} catch (err) {
119+
if (err instanceof AppError) {
120+
throw err;
121121
}
122122
// else
123123
this.logger.error({
124124
msg: 'unfamiliar error',
125125
logContext,
126-
error,
126+
err,
127127
});
128-
throw new AppError('error', StatusCodes.INTERNAL_SERVER_ERROR, String(error), true);
128+
throw new AppError('error', StatusCodes.INTERNAL_SERVER_ERROR, String(err), true);
129129
}
130130

131131
// else
@@ -152,13 +152,13 @@ export class ModelManager {
152152
try {
153153
const response: StoreTriggerResponse = await this.storeTrigger.postPayload(request);
154154
return response;
155-
} catch (error) {
155+
} catch (err) {
156156
this.logger.error({
157157
msg: 'Error in creating a flow',
158158
logContext,
159159
modelId,
160160
modelName: payload.metadata.productName,
161-
error,
161+
err,
162162
payload,
163163
});
164164
throw new AppError('', StatusCodes.INTERNAL_SERVER_ERROR, ERROR_STORE_TRIGGER_ERROR, true);

‎src/providers/s3Provider.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ export class S3Provider implements Provider {
5454
try {
5555
const response = await this.s3.send(new GetObjectCommand(getParams));
5656
return await response.Body!.transformToString();
57-
} catch (error) {
57+
} catch (err) {
5858
this.logger.error({
5959
mag: 'Problem during get file from S3',
6060
logContext,
6161
bucket: this.s3Config.bucket,
6262
path: filePath,
63-
error,
63+
err,
6464
});
65-
throw new AppError('', StatusCodes.INTERNAL_SERVER_ERROR, String(error), true);
65+
throw new AppError('', StatusCodes.INTERNAL_SERVER_ERROR, String(err), true);
6666
}
6767
}
6868
}

‎src/validator/validationManager.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,13 +263,13 @@ export class ValidationManager {
263263
} else {
264264
outReason.outFailedReason = ERROR_METADATA_BAD_FORMAT_TILESET;
265265
}
266-
} catch (error) {
266+
} catch (err) {
267267
const msg = ERROR_METADATA_ERRORED_TILESET;
268268
this.logger.error({
269269
msg: msg,
270270
logContext,
271271
fileContent,
272-
error,
272+
err,
273273
});
274274
// eslint-disable-next-line @typescript-eslint/no-unused-vars
275275
outReason.outFailedReason = msg;
@@ -370,12 +370,12 @@ export class ValidationManager {
370370
return {
371371
isValid: true,
372372
};
373-
} catch (error) {
373+
} catch (err) {
374374
const msg = `An error caused during the validation of the intersection`;
375375
this.logger.error({
376376
msg,
377377
logContext,
378-
error,
378+
err,
379379
modelPolygon,
380380
footprint,
381381
});

0 commit comments

Comments
 (0)