[API-913] Implement tag-types (#123)

* attempt

* Finalize tagTypes

* Remove broken test

Author: Mechazawa

src/Maps4News.js

@@ -67,6 +67,7 @@ import {
   Svg,
   SvgSet,
   Tag,
+  TagType,
   User,
 } from './resources';
 import ResourceBase from './resources/base/ResourceBase';
@@ -336,6 +337,15 @@ export default class Maps4News extends mix(null, Injectable) {
     return this.static(Tag);
   }
 
+  /**
+   * Tag accessor
+   * @see {@link Tag}
+   * @returns {ResourceProxy} - A proxy for accessing the resource
+   */
+  get tagTypes () {
+    return this.static(TagType);
+  }
+
   /**
    * Contract accessor
    * @see {@link Contract}

src/resources/Tag.js

@@ -30,17 +30,21 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-import CrudBase from './base/CrudBase';
 import OwnableResource from '../traits/OwnableResource';
 import { mix } from '../utils/reflection';
+import CrudSetItemBase from './base/CrudSetItemBase';
 
 /**
  * Tag resource
- * @extends CrudBase
+ * @extends CrudSetItemBase
  * @mixes OwnableResource
  */
-export default class Tag extends mix(CrudBase, OwnableResource) {
+export default class Tag extends mix(CrudSetItemBase, OwnableResource) {
   static get resourceName () {
     return 'tags';
   }
+
+  static get parentKey () {
+    return 'tag_type_id';
+  }
 }

tests/unit/ResourceLister.test.js src/resources/TagType.jstests/unit/ResourceLister.test.js renamed to src/resources/TagType.js

@@ -30,39 +30,33 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+import CrudSetBase from './base/CrudSetBase';
+import Tag from './Tag';
 
-import moxios from 'moxios';
-import Maps4News from '../../src/Maps4News';
-
-const api = new Maps4News('token', 'https://example.com');
-
-test('lister update should stop if it gets a 500', async () => {
-  moxios.wait(() => {
-    const request = moxios.requests.mostRecent();
-
-    request.respondWith({
-      status: 500,
-      response: {
-        success: false,
-        error: {
-          type: 'ServerError',
-          message: 'Something broke',
-        },
-      },
-    });
-  });
+/**
+ * TagType resource
+ * @mixes CrudSetBase
+ */
+export default class TagType extends CrudSetBase {
+  static get resourcePath () {
+    return '/tags/types/{id}';
+  }
 
-  const lister = api.users.lister({}, 0);
+  static get resourceName () {
+    return 'tag-types';
+  }
 
-  lister.autoUpdate = false;
+  get _Child () {
+    return Tag;
+  }
 
-  lister.maxRows = 50;
+  /**
+   * Get items associated with the set
+   * @returns {SimpleResourceProxy} - A proxy for accessing the resource
+   */
+  get items () {
+    const data = { [this.constructor.foreignKeyName]: this.id };
 
-  try {
-    await lister.update();
-  } catch (error) {
-    expect(error.type).toEqual('ServerError');
-    expect(error.message).toEqual('Something broke');
+    return this._proxyResourceList(this._Child, `${this.url}/tags`, data);
   }
-});
-
+}

src/resources/base/CrudSetItemBase.js

@@ -32,6 +32,7 @@
 
 import { AbstractClassError } from '../../errors/AbstractError';
 import CrudBase from './CrudBase';
+import { camel as camelCase } from 'case';
 
 /**
  * Items that are part of a set
@@ -50,16 +51,24 @@ export default class CrudSetItemBase extends CrudBase {
     }
   }
 
+  get hasParent () {
+    const parentKey = camelCase(this.constructor.parentKey);
+
+    return this.hasOwnProperty(parentKey);
+  }
+
   /**
    * Get the parent id
-   * @returns {?number|undefined} - Parent number
+   * @returns {number|undefined} - Parent number
    */
   get parentId () {
     if (this.hasParent) {
-      return Number(this[this.constructor.parentKey]);
+      const parentKey = camelCase(this.constructor.parentKey);
+
+      return Number(this[parentKey]);
     }
 
-    return [][0]; // same as "undefined"
+    return void 0;
   }
 
   /**

src/resources/index.js

@@ -60,6 +60,7 @@ export Role from './Role';
 export Svg from './Svg';
 export SvgSet from './SvgSet';
 export Tag from './Tag';
+export TagType from './TagType';
 export User from './User';
 
 import CrudBase from './base/CrudBase';