#fix 242 open generic setting shouldn't have side effect

Author: chaowlert

src/Mapster.Tests/WhenMappingWithOpenGenerics.cs

@@ -22,6 +22,20 @@ public void Map_With_Open_Generics()
             dto.value.ShouldBe(poco.Value);
         }
 
+        [TestMethod]
+        public void Setting_From_OpenGeneric_Has_No_SideEffect()
+        {
+            var config = new TypeAdapterConfig();
+            config
+                .NewConfig(typeof(A<>), typeof(B<>))
+                .Map("BProperty", "AProperty");
+
+            var a = new A<C> { AProperty = "A" };
+            var c = new C { BProperty = "C" };
+            var b = a.Adapt<B<C>>(config); // successful mapping
+            var cCopy = c.Adapt<C>(config);
+        }
+
         public class GenericPoco<T>
         {
             public T Value { get; set; }
@@ -31,6 +45,11 @@ public class GenericDto<T>
         {
             public T value { get; set; }
         }
-            
+         
+        class A<T> { public string AProperty { get; set; } }
+
+        class B<T> { public string BProperty { get; set; } }
+
+        class C { public string BProperty { get; set; } }
     }
 }

src/Mapster/Mapster.csproj

@@ -19,7 +19,7 @@
     <NetStandardImplicitPackageVersion Condition=" '$(TargetFramework)' == 'netstandard1.3' ">1.6.1</NetStandardImplicitPackageVersion>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <RootNamespace>Mapster</RootNamespace>
-    <Version>5.3.1</Version>
+    <Version>5.3.2</Version>
     <LangVersion>8.0</LangVersion>
     <Nullable>enable</Nullable>
     <NoWarn>1701;1702;8618</NoWarn>

src/Mapster/TypeAdapterConfig.cs

@@ -219,7 +219,9 @@ private static TypeAdapterRule CreateDestinationTypeRule(TypeTuple key)
                     score--;
                     type1 = type1.GetTypeInfo().BaseType;
                 }
-                return type1 == null ? null : (int?)score;
+                return type1 != null && type1.GetTypeInfo().IsGenericType && type1.GetGenericTypeDefinition() == type2 
+                    ? (int?)score
+                    : null;
             }
             if (!allowInheritance)
                 return null;
@@ -302,8 +304,7 @@ internal MethodCallExpression GetProjectionCallExpression(Type sourceType, Type
         private Dictionary<TypeTuple, Delegate>? _dynamicMapDict;
         internal Func<object, TDestination> GetDynamicMapFunction<TDestination>(Type sourceType)
         {
-            if (_dynamicMapDict == null)
-                _dynamicMapDict = new Dictionary<TypeTuple, Delegate>();
+            _dynamicMapDict ??= new Dictionary<TypeTuple, Delegate>();
             var key = new TypeTuple(sourceType, typeof(TDestination));
             if (!_dynamicMapDict.TryGetValue(key, out var del)) 
                 del = AddToHash(_dynamicMapDict, key, tuple => Compiler(CreateDynamicMapExpression(tuple)));
@@ -618,8 +619,7 @@ public TypeAdapterConfig Fork(Action<TypeAdapterConfig> action,
 #endif
             int key2 = 0)
         {
-            if (_inlineConfigs == null)
-                _inlineConfigs = new Dictionary<string, TypeAdapterConfig>();
+            _inlineConfigs ??= new Dictionary<string, TypeAdapterConfig>();
             var key = key1 + '|' + key2;
             if (_inlineConfigs.TryGetValue(key, out var config))
                 return config;