This repository was archived by the owner on May 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
room claim is always set to * #331
Copy link
Copy link
Open
Description
jitsi-openid always creates a JWT with a room claim set to *:
Line 156 in eb7b9d7
| "*".to_string(), |
The room is saved to the session, and is used in that same handler to construct a final URL to send to Jitsi Meet:
Line 165 in eb7b9d7
| let mut url = state.config.jitsi_url.join(&session.room).unwrap(); |
Also, the room session attribute itself is set from an external input:
Lines 36 to 40 in eb7b9d7
| async fn room( | |
| Path(room): Path<String>, | |
| State(state): State<JitsiState>, | |
| jar: CookieJar, | |
| ) -> impl IntoResponse { |
This should reject setting it to *.
Properly scoping the JWT means you could also run the token_no_wildcard contrib plugin, so that Jitsi Meet any rejects token containing wildcards in the sub or room parameters, which could limit the scope of another security issue.
Metadata
Metadata
Assignees
Labels
No labels