Skip to content

Commit e40fa51

Browse files
fix: Fix #49 (crash when hex escape is negative)
1 parent 38f62b7 commit e40fa51

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

parser/astgen/eval_literal.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,12 @@ def _handle_hex_escape(self, length, i, start_i):
6464
raise self.err(
6565
f"Unterminated escape in string (expected {length}"
6666
f" hex digits)", StrRegion(start_i, i))
67-
try:
68-
value = int(digits, base=16)
69-
except ValueError:
67+
if set(digits) - _HEX_DIGITS:
7068
# Just report entire escape as error region
7169
raise self.err(
7270
f"Invalid escape in string (expected {length} hex digits)",
73-
StrRegion(start_i, i)) from None
71+
StrRegion(start_i, i))
72+
value = int(digits, base=16) # Should never be error here (only hex digits here)
7473
return chr(value), i
7574

7675
# the Very Special Case: \N{......}
@@ -129,3 +128,4 @@ def err(self, msg: str, subregion: StrRegion):
129128
'u': 4, # \uHHHH
130129
'U': 8, # \Uhhhhhhhh
131130
}
131+
_HEX_DIGITS = set('0123456789abcdef')

0 commit comments

Comments
 (0)