Skip to content

Commit 039b908

Browse files
committed
feat: improve code readability by formatting conditionals and updating test workflow
1 parent e01f7ea commit 039b908

File tree

3 files changed

+16
-9
lines changed

3 files changed

+16
-9
lines changed

.github/workflows/tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ jobs:
3131
pip install poetry==1.3.1
3232
poetry install
3333
34-
- name: 🧪 Run tests
35-
run: poetry run pytest
36-
3734
- name: 📊 Run tests with coverage
3835
run: poetry run pytest --cov=src/ --cov-report=xml --cov-fail-under 90 --cov-config=.coveragerc
3936

src/openapi_python_generator/language_converters/python/model_generator.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,9 @@ def type_converter( # noqa: C901
191191
converted_type = pre_type + "bool" + post_type
192192
elif schema.type == "array" or str(schema.type) == "DataType.ARRAY":
193193
retVal = pre_type + "List["
194-
if isinstance(schema.items, Reference30) or isinstance(schema.items, Reference31):
194+
if isinstance(schema.items, Reference30) or isinstance(
195+
schema.items, Reference31
196+
):
195197
converted_reference = _generate_property_from_reference(
196198
model_name or "", "", schema.items, schema, required
197199
)

src/openapi_python_generator/language_converters/python/service_generator.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def is_response_type(obj) -> bool:
6161

6262

6363
def create_media_type_for_reference(
64-
reference_obj: Union[Response30, Reference30 , Response31 , Reference31],
64+
reference_obj: Union[Response30, Reference30, Response31, Reference31],
6565
):
6666
"""Create a MediaType wrapper for a reference object, using the correct version"""
6767
# Check which version the reference object belongs to
@@ -96,7 +96,9 @@ def generate_body_param(operation: Operation) -> Union[str, None]:
9696
if operation.requestBody is None:
9797
return None
9898
else:
99-
if isinstance(operation.requestBody, Reference30) or isinstance(operation.requestBody, Reference31):
99+
if isinstance(operation.requestBody, Reference30) or isinstance(
100+
operation.requestBody, Reference31
101+
):
100102
return "data.dict()"
101103

102104
if operation.requestBody.content is None:
@@ -156,18 +158,24 @@ def _generate_params_from_content(content: Any):
156158
required = False
157159
param_name_cleaned = common.normalize_symbol(param.name)
158160

159-
if isinstance(param.param_schema, Schema30) or isinstance(param.param_schema, Schema31):
161+
if isinstance(param.param_schema, Schema30) or isinstance(
162+
param.param_schema, Schema31
163+
):
160164
converted_result = (
161165
f"{param_name_cleaned} : {type_converter(param.param_schema, param.required).converted_type}"
162166
+ ("" if param.required else " = None")
163167
)
164168
required = param.required
165-
elif isinstance(param.param_schema, Reference30) or isinstance(param.param_schema, Reference31):
169+
elif isinstance(param.param_schema, Reference30) or isinstance(
170+
param.param_schema, Reference31
171+
):
166172
converted_result = (
167173
f"{param_name_cleaned} : {param.param_schema.ref.split('/')[-1] }"
168174
+ (
169175
""
170-
if isinstance(param, Reference30) or isinstance(param, Reference31) or param.required
176+
if isinstance(param, Reference30)
177+
or isinstance(param, Reference31)
178+
or param.required
171179
else " = None"
172180
)
173181
)

0 commit comments

Comments
 (0)