- Removed formatter option, as it seems a bit unnecessary

Author: MarcoMuellner

pyproject.toml

@@ -23,7 +23,6 @@ pydantic = "^1.9.1"
 orjson = "^3.7.2"
 openapi-schema-pydantic = "^1.2.3"
 Jinja2 = "^3.1.2"
-autopep8 = "^1.6.0"
 click = "^8.1.3"
 black = ">=21.10b0"
 

src/openapi_python_generator/__main__.py

@@ -3,7 +3,7 @@
 import click
 
 from openapi_python_generator import __version__
-from openapi_python_generator.common import HTTPLibrary, AutoFormat
+from openapi_python_generator.common import HTTPLibrary
 from openapi_python_generator.generate_data import generate_data
 
 
@@ -16,15 +16,9 @@
     type=HTTPLibrary,
     help="HTTP library to use in the generation of the client.",
 )
-@click.option(
-    "--autoformat",
-    default=AutoFormat.black,
-    type=AutoFormat,
-    help="Option to choose which auto formatter is applied.",
-)
 @click.option(
     "--env-token-name",
-    default=None,
+    default="access_token",
     help="Name of the environment variable that contains the token. If you set this, the code expects this environment "
     "variable to be set and will raise an error if it is not.",
 )
@@ -33,7 +27,6 @@ def main(
     source: str,
     output: str,
     library: Optional[HTTPLibrary] = HTTPLibrary.httpx,
-    autoformat: Optional[AutoFormat] = AutoFormat.black,
     env_token_name: Optional[str] = None,
 ) -> None:
     """
@@ -42,7 +35,7 @@ def main(
     Provide a SOURCE (file or URL) containing the OpenAPI 3 specification and
     an OUTPUT path, where the resulting client is created.
     """
-    generate_data(source, output, library, autoformat, env_token_name)
+    generate_data(source, output, library, env_token_name)
 
 
 if __name__ == "__main__":  # pragma: no cover

src/openapi_python_generator/common.py

@@ -14,16 +14,6 @@ class HTTPLibrary(str, Enum):
     aiohttp = "aiohttp"
 
 
-class AutoFormat(str, Enum):
-    """
-    Enum for the available autoformat options
-    """
-
-    autopep8 = "autopep8"
-    black = "black"
-    none = "none"
-
-
 library_config_dict: Dict[Optional[HTTPLibrary], LibraryConfig] = {
     HTTPLibrary.httpx: LibraryConfig(
         name="httpx",

src/openapi_python_generator/generate_data.py

@@ -7,35 +7,26 @@
 from httpx import ConnectError, ConnectTimeout
 import orjson
 from pydantic import ValidationError
-import autopep8
 
 from openapi_schema_pydantic import OpenAPI
-from .common import HTTPLibrary, library_config_dict, AutoFormat
+from .common import HTTPLibrary, library_config_dict
 from .language_converters.python.generator import generator
 from .language_converters.python.jinja_config import JINJA_ENV, SERVICE_TEMPLATE
 from .models import ConversionResult
 
 
-def write_code(
-    path: Path, content, autoformat: Optional[AutoFormat] = AutoFormat.black
-) -> None:
+def write_code(path: Path, content) -> None:
     """
     Write the content to the file at the given path.
     :param autoformat: The autoformat applied to the code written.
     :param path: The path to the file.
     :param content: The content to write.
     """
     with open(path, "w") as f:
-        if autoformat == AutoFormat.black:
-            f.write(
-                black.format_file_contents(
-                    content, fast=False, mode=black.FileMode(line_length=120)
-                )
-            )
-        elif autoformat == AutoFormat.autopep8:
-            f.write(autopep8.fix_code(content, options={"max_line_length": 120}))
-        else:
-            f.write(content)
+        formatted_contend = black.format_file_contents(
+            content, fast=False, mode=black.FileMode(line_length=120)
+        )
+        f.write(formatted_contend)
 
 
 def get_open_api(source: Union[str, Path]) -> OpenAPI:
@@ -67,11 +58,7 @@ def get_open_api(source: Union[str, Path]) -> OpenAPI:
         raise
 
 
-def write_data(
-    data: ConversionResult,
-    output: Union[str, Path],
-    autoformat: Optional[AutoFormat] = AutoFormat.black,
-) -> None:
+def write_data(data: ConversionResult, output: Union[str, Path]) -> None:
     """
     This function will firstly create the folderstrucutre of output, if it doesn't exist. Then it will create the
     models from data.models into the models sub module of the output folder. After this, the services will be created
@@ -97,13 +84,12 @@ def write_data(
     # Write the models.
     for model in data.models:
         files.append(model.file_name)
-        write_code(models_path / f"{model.file_name}.py", model.content, autoformat)
+        write_code(models_path / f"{model.file_name}.py", model.content)
 
     # Create models.__init__.py file containing imports to all models.
     write_code(
         models_path / "__init__.py",
         "\n".join([f"from .{file} import *" for file in files]),
-        autoformat,
     )
 
     files = []
@@ -116,32 +102,28 @@ def write_data(
         write_code(
             services_path / f"{service.file_name}.py",
             JINJA_ENV.get_template(SERVICE_TEMPLATE).render(**service.dict()),
-            autoformat,
         )
 
     # Create services.__init__.py file containing imports to all services.
     write_code(
         services_path / "__init__.py",
         "\n".join([f"from .{file} import *" for file in files]),
-        autoformat,
     )
 
     # Write the api_config.py file.
-    write_code(Path(output) / "api_config.py", data.api_config.content, autoformat)
+    write_code(Path(output) / "api_config.py", data.api_config.content)
 
     # Write the __init__.py file.
     write_code(
         Path(output) / "__init__.py",
         "from .models import *\nfrom .services import *\nfrom .api_config import *",
-        autoformat,
     )
 
 
 def generate_data(
     source: Union[str, Path],
     output: Union[str, Path],
     library: Optional[HTTPLibrary] = HTTPLibrary.httpx,
-    autoformat: Optional[AutoFormat] = AutoFormat.black,
     env_token_name: Optional[str] = None,
 ) -> None:
     """
@@ -150,4 +132,4 @@ def generate_data(
     data = get_open_api(source)
     click.echo(f"Generating data from {source}")
     result = generator(data, library_config_dict[library], env_token_name)
-    write_data(result, output, autoformat)
+    write_data(result, output)

tests/test_generate_data.py

@@ -1,7 +1,7 @@
 import pytest
 from httpx import ConnectError
 
-from openapi_python_generator.common import library_config_dict, HTTPLibrary, AutoFormat
+from openapi_python_generator.common import library_config_dict, HTTPLibrary
 from openapi_python_generator.generate_data import (
     get_open_api,
     write_data,
@@ -43,12 +43,9 @@ def test_generate_data(model_data_with_cleanup):
     assert (test_result_path / "__init__.py").is_file()
 
 
-@pytest.mark.parametrize(
-    "autoformat", [AutoFormat.black, AutoFormat.autopep8, AutoFormat.none]
-)
-def test_write_data(model_data_with_cleanup, autoformat):
+def test_write_data(model_data_with_cleanup):
     result = generator(model_data_with_cleanup, library_config_dict[HTTPLibrary.httpx])
-    write_data(result, test_result_path, autoformat)
+    write_data(result, test_result_path)
 
     assert test_result_path.exists()
     assert test_result_path.is_dir()

tests/test_main.py

@@ -3,7 +3,7 @@
 from click.testing import CliRunner
 
 from openapi_python_generator.__main__ import main
-from openapi_python_generator.common import HTTPLibrary, AutoFormat
+from openapi_python_generator.common import HTTPLibrary
 from tests.conftest import test_data_path, test_result_path
 
 
@@ -14,29 +14,16 @@ def runner() -> CliRunner:
 
 
 @pytest.mark.parametrize(
-    "library,autoformat",
+    "library",
     [
-        (HTTPLibrary.httpx, AutoFormat.black),
-        (HTTPLibrary.httpx, AutoFormat.autopep8),
-        (HTTPLibrary.httpx, AutoFormat.none),
-        (HTTPLibrary.requests, AutoFormat.black),
-        (HTTPLibrary.requests, AutoFormat.autopep8),
-        (HTTPLibrary.requests, AutoFormat.none),
+        HTTPLibrary.httpx,
+        HTTPLibrary.requests,
     ],
 )
-def test_main_succeeds(
-    runner: CliRunner, model_data_with_cleanup, library, autoformat
-) -> None:
+def test_main_succeeds(runner: CliRunner, model_data_with_cleanup, library) -> None:
     """It exits with a status code of zero."""
     result = runner.invoke(
         main,
-        [
-            str(test_data_path),
-            str(test_result_path),
-            "--library",
-            library.value,
-            "--autoformat",
-            autoformat.value,
-        ],
+        [str(test_data_path), str(test_result_path), "--library", library.value],
     )
     assert result.exit_code == 0