Skip to content

Commit 0e4a682

Browse files
committed
Fix some compilation warnings
1 parent c9f3a97 commit 0e4a682

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

codeql-custom-queries-java/queries/gson/TypeToken-capturing-type-variable.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ where
3737
and typeVariable = getAReferencedTypeVariable(parameterizedTypeToken)
3838
// Ignore Kotlin reified type variable because that is actually safe
3939
and not typeVariable.isReified()
40-
select typeTokenCreation, "Capturing type variable $@ is not type safe", typeVariable.getName(), typeVariable
40+
select typeTokenCreation, "Capturing type variable $@ is not type safe", typeVariable, typeVariable.getName()

codeql-custom-queries-java/queries/performance/short-circuiting-operator-with-expensive-before-cheap-operand.ql

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,6 @@ class NonLocalVarModifyingExpr extends ModifyingExpr {
8181
}
8282
}
8383

84-
class NonModifyingExpr extends Expr {
85-
NonModifyingExpr() {
86-
not this instanceof ModifyingExpr
87-
}
88-
}
89-
9084
class CheapMethodCall extends MethodAccess {
9185
CheapMethodCall() {
9286
exists (Method m, BlockStmt body | m = getMethod() and body = m.getBody() |

codeql-custom-queries-java/queries/recommendations/non-deterministic-Set-or-Map-iteration-order.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
* Note that the precision of this query is rather low, in many cases the iteration order
99
* is irrelevant.
1010
*
11+
* @kind problem
1112
* @precision low
1213
*/
1314

codeql-custom-queries-java/queries/security/readObject-not-validating-default-read-field.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* `defaultReadObject()` and then validates some field values, but which does
44
* not validate the value of one of the other deserialized fields.
55
*
6+
* @kind problem
67
* @precision low
78
*/
89

0 commit comments

Comments
 (0)