Improve empty-array-ignored-dimensions.ql

Tested query with Variant Analysis and had a few results, though only
in contrived test code apparently.

Author: Marcono1234

codeql-custom-queries-java/not-tested-queries/empty-array-ignored-dimensions.ql renamed to codeql-custom-queries-java/queries/likely-bugs/empty-array-ignored-dimensions.ql

@@ -5,10 +5,12 @@
  * which indicates that the code might not behave the way it was originally
  * designed:
  * `new int[0][10][getSize()]` is the same as
- * ```
+ * ```java
  * getSize()
  * new int[0][][];
  * ```
+ * 
+ * @kind problem
  */
 
 import java
@@ -19,13 +21,11 @@ class ZeroConstant extends CompileTimeConstantExpr {
     }
 }
 
-from ArrayCreationExpr newArrayExpr
+from ArrayCreationExpr newArrayExpr, ZeroConstant zeroDimExpr, Expr otherDimExpr
 where
-    exists (ZeroConstant zeroDimExpr, Expr otherDimExpr |
-        zeroDimExpr = newArrayExpr.getADimension()
-        and otherDimExpr = newArrayExpr.getADimension()
-        // otherDimExpr appears behind 0 dim expression
-        and zeroDimExpr.getIndex() < otherDimExpr.getIndex()
-        and not otherDimExpr instanceof ZeroConstant
-    )
-select newArrayExpr
+    zeroDimExpr = newArrayExpr.getADimension()
+    and otherDimExpr = newArrayExpr.getADimension()
+    // otherDimExpr appears behind 0 dim expression
+    and zeroDimExpr.getIndex() < otherDimExpr.getIndex()
+    and not otherDimExpr instanceof ZeroConstant
+select otherDimExpr, "Pointless dimension argument because enclosing array has $@", zeroDimExpr, "size 0"