Fix all clippy warnings

Author: Marenz

src/audio.rs

@@ -23,7 +23,7 @@ pub enum AudioFormat {
 }
 
 impl AudioFormat {
-    pub fn from_str(s: &str) -> Option<Self> {
+    pub fn parse(s: &str) -> Option<Self> {
         match s.to_lowercase().as_str() {
             "wav" => Some(Self::Wav),
             "ogg" | "vorbis" => Some(Self::Ogg),
@@ -72,7 +72,7 @@ pub fn write_audio(
         .unwrap_or("wav")
         .to_lowercase();
 
-    match AudioFormat::from_str(&ext) {
+    match AudioFormat::parse(&ext) {
         Some(AudioFormat::Wav) => write_wav(path, samples, sample_rate, num_channels),
         #[cfg(feature = "audio-ogg")]
         Some(AudioFormat::Ogg) => ogg::write_ogg(path, samples, sample_rate, num_channels),

src/audio/ogg.rs

@@ -2,7 +2,7 @@
 
 use crate::Result;
 use std::io::Write;
-use std::num::{NonZeroU8, NonZeroU32};
+use std::num::{NonZeroU32, NonZeroU8};
 
 pub fn write_ogg_to<W: Write>(
     writer: W,

src/audio/wav.rs

@@ -50,6 +50,7 @@ pub fn write_wav(
 }
 
 /// Peak-normalize audio samples to [-1, 1].
+#[allow(dead_code)]
 pub fn peak_normalize(samples: &mut [f32]) {
     let max_abs = samples.iter().map(|s| s.abs()).fold(0.0f32, f32::max);
     if max_abs > 1e-8 {
@@ -175,7 +176,7 @@ mod tests {
         let prev = vec![1.0f32; 16]; // 8 stereo frames
         let next = vec![0.0f32; 16];
         let result = crossfade(&prev, &next, 4, 2); // 4-frame crossfade
-        // (16-8) + 8 + (16-8) = 24
+                                                    // (16-8) + 8 + (16-8) = 24
         assert_eq!(result.len(), 24);
     }
 

src/bin/ace-step.rs

@@ -91,15 +91,15 @@ fn main() -> anyhow::Result<()> {
         .and_then(|e| e.to_str())
         .unwrap_or("wav");
 
-    if ace_step_rs::audio::AudioFormat::from_str(ext).is_none() {
+    if ace_step_rs::audio::AudioFormat::parse(ext).is_none() {
         anyhow::bail!("unsupported output format '{}'. Use .wav or .ogg", ext);
     }
 
     // Ensure output directory exists
-    if let Some(parent) = output_path.parent() {
-        if !parent.as_os_str().is_empty() {
-            std::fs::create_dir_all(parent)?;
-        }
+    if let Some(parent) = output_path.parent()
+        && !parent.as_os_str().is_empty()
+    {
+        std::fs::create_dir_all(parent)?;
     }
 
     let device = candle_core::Device::cuda_if_available(0)?;

src/bin/generation-daemon.rs

@@ -257,7 +257,7 @@ async fn process_request(line: &str, manager: &GenerationManager) -> Response {
         .extension()
         .and_then(|e| e.to_str())
         .unwrap_or("wav");
-    if ace_step_rs::audio::AudioFormat::from_str(ext).is_none() {
+    if ace_step_rs::audio::AudioFormat::parse(ext).is_none() {
         return Response::err(format!(
             "unsupported output format '{ext}'. Use .wav or .ogg"
         ));

src/manager.rs

@@ -190,6 +190,7 @@ fn maybe_proactive_offload(pipeline: AceStepPipeline, config: &ManagerConfig) ->
 ///
 /// On success returns the CPU pipeline.
 /// On failure returns the original error and a recovered pipeline (reloaded on GPU).
+#[allow(clippy::result_large_err)]
 fn offload_to_cpu(
     pipeline: AceStepPipeline,
     config: &ManagerConfig,

src/model/encoder/timbre.rs

@@ -14,6 +14,7 @@ use crate::model::transformer::mask::create_4d_mask;
 
 /// Timbre encoder matching Python `AceStepTimbreEncoder`.
 #[derive(Debug, Clone)]
+#[allow(dead_code)]
 pub struct AceStepTimbreEncoder {
     embed_tokens: nn::Linear,
     norm: RmsNorm,
@@ -125,9 +126,9 @@ impl AceStepTimbreEncoder {
         }
 
         // Build mask
-        for bid in 0..b {
+        for count in &counts {
             for pos in 0..max_count {
-                mask_vals.push(if pos < counts[bid] { 1i64 } else { 0i64 });
+                mask_vals.push(if pos < *count { 1i64 } else { 0i64 });
             }
         }
 

src/model/generation.rs

@@ -23,6 +23,7 @@ pub struct GenerationOutput {
 pub struct AceStepConditionGenerationModel {
     decoder: AceStepDiTModel,
     encoder: AceStepConditionEncoder,
+    #[allow(dead_code)]
     null_condition_emb: Tensor, // [1, 1, hidden_size]
     cfg: AceStepConfig,
 }
@@ -87,6 +88,7 @@ impl AceStepConditionGenerationModel {
     /// Generate audio latents from text/lyrics/timbre conditions.
     ///
     /// Returns latents [B, T, 64] at 25Hz, ready for VAE decoding.
+    #[allow(clippy::too_many_arguments)]
     pub fn generate_audio(
         &self,
         text_hidden_states: &Tensor,

src/model/tokenizer/fsq.rs

@@ -10,6 +10,7 @@ use candle_core::{Result, Tensor};
 /// For inference we only need the forward pass (quantize) and
 /// `get_output_from_indices` (decode codes back to continuous).
 #[derive(Debug, Clone)]
+#[allow(dead_code)]
 pub struct ResidualFsq {
     /// Project from hidden_size to FSQ dim
     project_in: Option<candle_nn::Linear>,

src/model/transformer/attention.rs

@@ -128,6 +128,7 @@ pub struct AceStepAttention {
     head_dim: usize,
     scaling: f64,
     is_cross_attention: bool,
+    #[allow(dead_code)]
     sliding_window: Option<usize>,
 }