more exception testing

Author: i-make-robots

src/main/java/com/marginallyclever/makelangelo/donatelloimpl/nodes/turtle/PathImageMask.java

@@ -61,7 +61,7 @@ public void update() {
 
         for (LineSegment2D line : lines) {
             scanLine(src, line, s, c);
-            setComplete(i++ * 100 / size);
+            setComplete(i++ * 99 / size);
         }
 
         Turtle resultAbove = new Turtle();

src/main/java/com/marginallyclever/makelangelo/donatelloimpl/nodes/turtle/PrintTurtle.java

@@ -53,6 +53,8 @@ public void update() {
             if (myTurtle == null || myTurtle.history.isEmpty()) return;
 
             generatePolylines(myTurtle);
+        } catch(Exception e) {
+            logger.error("Failed to update", e);
         } finally {
             lock.unlock();
         }
@@ -68,12 +70,14 @@ public void print(Graphics g) {
         GraphViewPanel.setHints(g2);
         g2.setRenderingHint(RenderingHints.KEY_ANTIALIASING, RenderingHints.VALUE_ANTIALIAS_ON);
         g2.setStroke(new BasicStroke(lineThickness.getValue()));
+
         lock.lock();
         try {
             polylines.forEach(p -> p.draw(g2));
         } finally {
             lock.unlock();
         }
+
         g2.dispose();
     }
 

src/main/java/com/marginallyclever/makelangelo/makeart/io/TurtleFactory.java

@@ -71,7 +71,9 @@ public static JFileChooser getSaveFileChooser() {
 	}
 
 	public static Turtle load(String filename) throws Exception {
-		if(filename == null || filename.trim().isEmpty()) throw new InvalidParameterException("filename cannot be empty");
+		if(filename == null || filename.trim().isEmpty()) {
+			throw new InvalidParameterException("filename cannot be empty");
+		}
 
 		for( TurtleLoader loader : loaders ) {
 			if(isValidExtension(filename,loader.getFileNameFilter())) {

src/main/java/com/marginallyclever/makelangelo/turtle/Turtle.java

@@ -439,30 +439,35 @@ public void addLineSegments(LineCollection segments) {
 	 */
 	public void addLineSegments(LineCollection segments, double minimumJumpSize, double minDrawDistance) {
 		if(segments.isEmpty()) return;
-		
-		LineSegment2D first = segments.get(0);
-		jumpTo(first.start.x,first.start.y);
-		moveTo(first.end.x,first.end.y);
-		
-		double minJumpSquared = minimumJumpSize*minimumJumpSize;
-		double minDrawSquared = minDrawDistance*minDrawDistance;
-		
-		for( LineSegment2D line : segments ) {
-			// change color if needed
-			if(line.color !=getColor()) {
-				setColor(line.color);
-			}
 
-			double d = distanceSquared(line.start);
-			if(d > minJumpSquared) {
-				// The previous line ends too far from the start point of this line,
-				// need to make a travel with the pen up to the start point of this line.
-				jumpTo(line.start.x,line.start.y);
-			} else if(d>minDrawSquared) {
-				moveTo(line.start.x,line.start.y);
+		lock();
+		try {
+			LineSegment2D first = segments.get(0);
+			jumpTo(first.start.x, first.start.y);
+			moveTo(first.end.x, first.end.y);
+
+			double minJumpSquared = minimumJumpSize * minimumJumpSize;
+			double minDrawSquared = minDrawDistance * minDrawDistance;
+
+			for (LineSegment2D line : segments) {
+				// change color if needed
+				if (line.color != getColor()) {
+					setColor(line.color);
+				}
+
+				double d = distanceSquared(line.start);
+				if (d > minJumpSquared) {
+					// The previous line ends too far from the start point of this line,
+					// need to make a travel with the pen up to the start point of this line.
+					jumpTo(line.start.x, line.start.y);
+				} else if (d > minDrawSquared) {
+					moveTo(line.start.x, line.start.y);
+				}
+				// Make a pen down move to the end of this line
+				moveTo(line.end.x, line.end.y);
 			}
-			// Make a pen down move to the end of this line
-			moveTo(line.end.x,line.end.y);
+		} finally {
+			unlock();
 		}
 	}