Skip to content

Commit 07314cf

Browse files
committed
Add testing, CI/CD, improve portability, and format all code
∙ - Add .isort.cfg for Black compatibility
1 parent 84a9647 commit 07314cf

File tree

11 files changed

+72
-30
lines changed

11 files changed

+72
-30
lines changed

.isort.cfg

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[settings]
2+
profile = black
3+
line_length = 88

tests/test_dataset_validation.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,7 @@ class MockArgs:
265265

266266
# This would need to be tested with actual training pipeline
267267
try:
268-
from train_hieroglyph_detection_robust import \
269-
HieroglyphTrainingConfig
268+
from train_hieroglyph_detection_robust import HieroglyphTrainingConfig
270269

271270
config = HieroglyphTrainingConfig(MockArgs())
272271
self.assertIsNotNone(config.run_id)

tools/data-collection/hieroglyph_scraping_toolkit/__init__.py

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,27 @@
2525
)
2626

2727
# Core modules
28-
from .config import (ConfigManager, LayoutConfiguration, PathConfig,
29-
WebScrapingConfig, create_default_config_file,
30-
get_config_manager)
31-
from .utils import (PerformanceTracker, ensure_directory, performance_tracker,
32-
progress_bar, retry_on_exception, safe_file_read,
33-
safe_file_write, safe_json_load, safe_json_save,
34-
setup_logging, timing_decorator)
28+
from .config import (
29+
ConfigManager,
30+
LayoutConfiguration,
31+
PathConfig,
32+
WebScrapingConfig,
33+
create_default_config_file,
34+
get_config_manager,
35+
)
36+
from .utils import (
37+
PerformanceTracker,
38+
ensure_directory,
39+
performance_tracker,
40+
progress_bar,
41+
retry_on_exception,
42+
safe_file_read,
43+
safe_file_write,
44+
safe_json_load,
45+
safe_json_save,
46+
setup_logging,
47+
timing_decorator,
48+
)
3549

3650
# Sub-packages are available but not automatically imported
3751
# Import them explicitly when needed:

tools/data-collection/hieroglyph_scraping_toolkit/scraping/aku_scraper.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
from selenium.webdriver.common.by import By
1414

1515
from ..config import WebScrapingConfig
16-
from ..utils import (clean_filename, safe_file_write, safe_json_save,
17-
timing_decorator)
16+
from ..utils import clean_filename, safe_file_write, safe_json_save, timing_decorator
1817
from .base_scraper import BaseScraper
1918

2019

tools/data-collection/hieroglyph_scraping_toolkit/scraping/base_scraper.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,12 @@
2020
from webdriver_manager.chrome import ChromeDriverManager
2121

2222
from ..config import WebScrapingConfig
23-
from ..utils import (ensure_directory, retry_on_exception, setup_logging,
24-
timing_decorator)
23+
from ..utils import (
24+
ensure_directory,
25+
retry_on_exception,
26+
setup_logging,
27+
timing_decorator,
28+
)
2529

2630

2731
class BaseScraper:

tools/data-collection/hieroglyph_scraping_toolkit/svg/processor.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,13 @@
1313

1414
import cairosvg
1515

16-
from ..utils import (extract_svg_dimensions, safe_file_read, safe_file_write,
17-
timing_decorator, validate_svg_content)
16+
from ..utils import (
17+
extract_svg_dimensions,
18+
safe_file_read,
19+
safe_file_write,
20+
timing_decorator,
21+
validate_svg_content,
22+
)
1823

1924

2025
class SVGProcessor:

tools/data-collection/list_signs_modular.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@
1717
# Add the toolkit to Python path
1818
sys.path.append(str(Path(__file__).parent / "hieroglyph_scraping_toolkit"))
1919

20-
from hieroglyph_scraping_toolkit import (create_default_config_file,
21-
get_config_manager, setup_logging)
20+
from hieroglyph_scraping_toolkit import (
21+
create_default_config_file,
22+
get_config_manager,
23+
setup_logging,
24+
)
2225

2326

2427
def main():

tools/data-collection/metadata_scraper_modular.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,14 @@
1818
# Add the toolkit to Python path
1919
sys.path.append(str(Path(__file__).parent / "hieroglyph_scraping_toolkit"))
2020

21-
from hieroglyph_scraping_toolkit import (create_default_config_file,
22-
get_config_manager, progress_bar,
23-
safe_file_read, safe_json_load,
24-
setup_logging)
21+
from hieroglyph_scraping_toolkit import (
22+
create_default_config_file,
23+
get_config_manager,
24+
progress_bar,
25+
safe_file_read,
26+
safe_json_load,
27+
setup_logging,
28+
)
2529

2630

2731
def load_sign_numbers(signs_file: str) -> List[str]:

tools/data-collection/svg_analyzer_modular.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,13 @@
1818
# Add the toolkit to Python path
1919
sys.path.append(str(Path(__file__).parent / "hieroglyph_scraping_toolkit"))
2020

21-
from hieroglyph_scraping_toolkit import (create_default_config_file,
22-
get_config_manager, progress_bar,
23-
safe_json_save, setup_logging)
21+
from hieroglyph_scraping_toolkit import (
22+
create_default_config_file,
23+
get_config_manager,
24+
progress_bar,
25+
safe_json_save,
26+
setup_logging,
27+
)
2428

2529

2630
def main():

tools/evaluation/generate_workflow_diagrams.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
import matplotlib.pyplot as plt
1111
import numpy as np
1212
import seaborn as sns
13-
from matplotlib.patches import (Arrow, Circle, ConnectionPatch, FancyBboxPatch,
14-
Rectangle)
13+
from matplotlib.patches import Arrow, Circle, ConnectionPatch, FancyBboxPatch, Rectangle
1514

1615
# Set style for professional plots
1716
plt.rcParams["font.family"] = "DejaVu Sans"

0 commit comments

Comments
 (0)