Skip to content

Commit 13113ec

Browse files
MDBF-1074 - EOL 10.5
This patch is targeted for buildbot release v1.0.7 I know I had an attempt to cover it in #756 but I don't like getting merge conflicts on constants.py. so it's better to separate the concerns a bit, remove 10.5 and then handle any platform deprecation / addition.
1 parent b2d5f2e commit 13113ec

File tree

7 files changed

+14
-31
lines changed

7 files changed

+14
-31
lines changed

common_factories.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -480,11 +480,7 @@ def addGaleraTests(factory, mtrDbPool):
480480

481481

482482
def addS3Tests(factory, mtrDbPool):
483-
runS3 = (
484-
lambda props: hasS3(props)
485-
and props.hasProperty("compile_step_completed")
486-
and "10.5" not in str(props.getProperty("master_branch"))
487-
)
483+
runS3 = lambda props: hasS3(props) and props.hasProperty("compile_step_completed")
488484
factory.addStep(
489485
steps.MasterShellCommand(
490486
name="Create minio S3 bucket",

constants.py

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
# Used to trigger the appropriate main branch
88
BRANCHES_MAIN = [
9-
"10.5",
109
"10.6",
1110
"10.11",
1211
"11.0",
@@ -101,7 +100,7 @@
101100
# Maximum supported branch is the one where the default distro MariaDB package major version <= branch
102101
# For example, if Debian 10 has MariaDB 10.3 by default, we don't support MariaDB 10.2 on it.
103102
SUPPORTED_PLATFORMS = {}
104-
SUPPORTED_PLATFORMS["10.5"] = [
103+
SUPPORTED_PLATFORMS["10.6"] = [
105104
"aarch64-centos-stream9",
106105
"aarch64-debian-11",
107106
"aarch64-macos",
@@ -111,6 +110,7 @@
111110
"aarch64-rhel-9",
112111
"aarch64-ubuntu-2004",
113112
"aarch64-ubuntu-2004-debug",
113+
"aarch64-ubuntu-2204",
114114
"amd64-centos-7-bintar",
115115
"amd64-centos-stream9",
116116
"amd64-debian-11",
@@ -119,6 +119,7 @@
119119
"amd64-debian-12-rocksdb",
120120
"amd64-fedora-40-valgrind",
121121
"amd64-freebsd-14",
122+
"amd64-msan-clang-20",
122123
"amd64-openeuler-2403",
123124
"amd64-rhel-7",
124125
"amd64-rhel-8",
@@ -128,6 +129,7 @@
128129
"amd64-ubuntu-2004",
129130
"amd64-ubuntu-2004-debug",
130131
"amd64-ubuntu-2004-fulltest",
132+
"amd64-ubuntu-2204",
131133
"amd64-ubuntu-2204-debug-ps",
132134
"amd64-ubuntu-2204-icc",
133135
"amd64-ubuntu-2404-clang18-asan",
@@ -140,23 +142,15 @@
140142
"ppc64le-ubuntu-2004",
141143
"ppc64le-ubuntu-2004-debug",
142144
"ppc64le-ubuntu-2004-without-server",
145+
"ppc64le-ubuntu-2204",
143146
"s390x-rhel-8",
144147
"s390x-rhel-9",
145148
"s390x-ubuntu-2004",
146149
"s390x-ubuntu-2004-debug",
147-
"x86-debian-12-fulltest",
148-
"x86-debian-12-fulltest-debug",
149-
]
150-
151-
SUPPORTED_PLATFORMS["10.6"] = SUPPORTED_PLATFORMS["10.5"].copy()
152-
153-
SUPPORTED_PLATFORMS["10.6"] += [
154-
"aarch64-ubuntu-2204",
155-
"amd64-msan-clang-20",
156-
"amd64-ubuntu-2204",
157-
"ppc64le-ubuntu-2204",
158150
"s390x-ubuntu-2204",
159151
"x86-debian-12",
152+
"x86-debian-12-fulltest",
153+
"x86-debian-12-fulltest-debug",
160154
]
161155

162156
SUPPORTED_PLATFORMS["10.9"] = SUPPORTED_PLATFORMS["10.6"].copy()

master-docker-nonstandard-2/master.cfg

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -491,9 +491,8 @@ class TestConfig:
491491
# Define a function to add test steps to a factory
492492
def add_test_steps(factory: BuildFactory, test_configs: Iterable[TestConfig]):
493493
def run_vault(step: BuildStep) -> bool:
494-
return all(
495-
item not in str(step.getProperty("master_branch"))
496-
for item in ["10.5", "10.6"]
494+
# Vault tests are not present in server versions <= 10.6, so we skip them for that version
495+
return "10.6" not in str(step.getProperty("master_branch")
497496
)
498497

499498
for test_config in test_configs:

master-web/templates/grid_view/grid.jade

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
ul
1414
li
1515
| Grid View for main branches:
16-
a(href="#grid?branch=10.5") 10.5
17-
| ,
1816
a(href="#grid?branch=10.6") 10.6
1917
| ,
2018
a(href="#grid?branch=10.11") 10.11

master-web/templates/home.jade

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
ul
1414
li
1515
| The Grid Display (
16-
a(href="#grid?branch=10.5") 10.5
17-
| ,
1816
a(href="#grid?branch=10.6") 10.6
1917
| ,
2018
a(href="#grid?branch=10.11") 10.11

scripts/aix-build-and-test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ rpl.rpl_xa_empty_transaction : NDEV-30222
8484
rpl.rpl_row_img_sequence_noblob : NDEV-30222
8585
main.mysql_client_test : mysqltest: At line 27: exec of '/home/buildbot/aix/build/build/tests/mysql_client_test - possibly LIBPATH related
8686
EOF
87-
case "${1:-mariadb-10.5.10}" in
88-
mariadb-10.[56].*)
87+
case "${1:-mariadb-10.6}" in
88+
mariadb-10.6.*)
8989
echo "innodb.log_buffer_size : Marko request" >> ../unstable-tests
9090
;;
9191
esac

utils.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -486,24 +486,22 @@ def hasDockerLibrary(step: BuildStep) -> bool:
486486
builder_name = step.getProperty("buildername")
487487

488488
# from https://github.com/MariaDB/mariadb-docker/blob/next/update.sh#L7-L15
489-
if fnmatch.fnmatch(branch, "10.[56]"):
489+
if fnmatch.fnmatch(branch, "10.6"):
490490
dockerbase = "ubuntu-2004-deb-autobake"
491491
elif fnmatch.fnmatch(branch, "10.11"):
492492
dockerbase = "ubuntu-2204-deb-autobake"
493493
else:
494494
dockerbase = "ubuntu-2404-deb-autobake"
495495

496496
# UBI images
497-
if branch != "10.5" and builder_name.endswith("amd64-rhel-9-rpm-autobake"):
497+
if builder_name.endswith("amd64-rhel-9-rpm-autobake"):
498498
return True
499499

500500
# We only build on the above autobakes for all architectures
501501
return builder_name.endswith(dockerbase)
502502

503503

504504
def filterBranch(step: BuildStep) -> str:
505-
if "10.5" in step.getProperty("branch"):
506-
return False
507505
if "10.6" in step.getProperty("branch"):
508506
return False
509507
return True

0 commit comments

Comments
 (0)