Replace msan clang 16 with clang 20 - Protected Builders

- remove msan clang 16 builder
- tag clang 20 builder as protected
- assign more powerful and stable builders to msan clang 20 builder. Increase the jobs
- add msan clang 20 to github status builder

Rollout plan:
- remove msan clang 16 from branch protection (GitHub)
- release this patch
- add msan clang 20 to branch protection

Author: RazvanLiviuVarzaru

constants.py

@@ -50,7 +50,7 @@
     "amd64-debian-12-debug-embedded",
     "amd64-debian-12-deb-autobake",
     "amd64-debian-11-debug-ps-embedded",
-    "amd64-debian-11-msan-clang-16",
+    "amd64-msan-clang-20",
     "amd64-fedora-40",
     "amd64-ubuntu-2004-debug",
     "amd64-ubuntu-2204-debug-ps",
@@ -115,7 +115,6 @@
     "amd64-centos-stream9",
     "amd64-debian-11",
     "amd64-debian-11-debug-ps-embedded",
-    "amd64-debian-11-msan-clang-16",
     "amd64-debian-12-asan-ubsan",
     "amd64-debian-12-rocksdb",
     "amd64-fedora-40-valgrind",

master-docker-nonstandard-2/master.cfg

@@ -104,14 +104,15 @@ for full_test_worker in ["debian-12-32-bit", "debian-12-32-bit-debug"]:
         )
 
 for msan_worker in ["msan-clang-20", "msan-clang-20-debug"]:
-    addWorker(
-        "apexis-bbw",
-        3,
-        msan_worker,
-        os.environ["CONTAINER_REGISTRY_URL"] + "debian12-msan-clang-20",
-        jobs=15,
-        save_packages=False,
-    )
+    for worker_id in [1,4,5]: # Hetzner designated workers for protected builds
+        addWorker(
+            "hz-bbw",
+            worker_id,
+            msan_worker,
+            os.environ["CONTAINER_REGISTRY_URL"] + "debian12-msan-clang-20",
+            jobs=20,
+            save_packages=False,
+        )
 
 addWorker(
     "apexis-bbw",
@@ -746,7 +747,7 @@ c["builders"].append(
     util.BuilderConfig(
         name="amd64-msan-clang-20",
         workernames=workers["x64-bbw-docker-msan-clang-20"],
-        tags=["Debian", "clang", "msan"],
+        tags=["Debian", "clang", "msan", "protected"],
         collapseRequests=True,
         nextBuild=nextBuild,
         canStartBuild=canStartBuild,

master-docker-nonstandard/master.cfg

@@ -297,31 +297,6 @@ addWorker(
     save_packages=False,
 )
 
-addWorker(
-    "hz-bbw",
-    1,
-    "msan-clang-16-debian-11",
-    os.environ["CONTAINER_REGISTRY_URL"] + "debian11-msan-clang-16",
-    jobs=20,
-    save_packages=False,
-)
-addWorker(
-    "hz-bbw",
-    4,
-    "msan-clang-16-debian-11",
-    os.environ["CONTAINER_REGISTRY_URL"] + "debian11-msan-clang-16",
-    jobs=20,
-    save_packages=False,
-)
-addWorker(
-    "hz-bbw",
-    5,
-    "msan-clang-16-debian-11",
-    os.environ["CONTAINER_REGISTRY_URL"] + "debian11-msan-clang-16",
-    jobs=20,
-    save_packages=False,
-)
-
 addWorker(
     "hz-bbw",
     2,
@@ -612,101 +587,6 @@ f_asan_build.addStep(
     )
 )
 
-## f_msan_build
-f_msan_build = util.BuildFactory()
-f_msan_build.addStep(printEnv())
-f_msan_build.addStep(
-    steps.ShellCommand(
-        name="create html log file",
-        command=[
-            "bash",
-            "-c",
-            util.Interpolate(
-                getHTMLLogString(),
-                jobs=util.Property("jobs", default="$(getconf _NPROCESSORS_ONLN)"),
-            ),
-        ],
-    )
-)
-f_msan_build.addStep(getSourceTarball())
-# build steps
-f_msan_build.addStep(steps.ShellCommand(command="ls /msan-libs"))
-f_msan_build.addStep(
-    steps.Compile(
-        command=[
-            "bash",
-            "-xc",
-            util.Interpolate(
-                'cmake . -DCMAKE_C_COMPILER=%(kw:c_compiler)s -DCMAKE_CXX_COMPILER=%(kw:cxx_compiler)s -DCMAKE_C_FLAGS="-O2 -Wno-unused-command-line-argument -fdebug-macro" -DCMAKE_CXX_FLAGS="-stdlib=libc++ -O2 -Wno-unused-command-line-argument -fdebug-macro" -DWITH_EMBEDDED_SERVER=OFF -DWITH_UNIT_TESTS=OFF -DCMAKE_BUILD_TYPE=Debug -DWITH_INNODB_{BZIP2,LZ4,LZMA,LZO,SNAPPY}=OFF -DPLUGIN_{ARCHIVE,TOKUDB,MROONGA,OQGRAPH,ROCKSDB,CONNECT,SPIDER}=NO -DWITH_SAFEMALLOC=OFF -DWITH_{ZLIB,SSL,PCRE}=bundled -DHAVE_LIBAIO_H=0 -DCMAKE_DISABLE_FIND_PACKAGE_{URING,LIBAIO}=1 -DWITH_MSAN=ON -DWITH_DBUG_TRACE=OFF && make -j%(kw:jobs)s package',
-                jobs=util.Property("jobs", default="$(getconf _NPROCESSORS_ONLN)"),
-                c_compiler=util.Property("c_compiler", default="clang"),
-                cxx_compiler=util.Property("cxx_compiler", default="clang++"),
-            ),
-        ],
-        haltOnFailure="true",
-    )
-)
-f_msan_build.addStep(
-    steps.MTR(
-        logfiles={"mysqld*": "./buildbot/mysql_logs.html"},
-        test_type="msan",
-        command=[
-            "bash",
-            "-xc",
-            util.Interpolate(
-                'cd mysql-test && LD_LIBRARY_PATH=/msan-libs MSAN_OPTIONS=abort_on_error=1:poison_in_dtor=0 ./mtr --mem --big-test --force --retry=0 --skip-test=".*compression.*|rpl\.rpl_non_direct_row_mixing_engines|perfschema\.table_io_aggregate_hist_\du_\dt|perfschema\.transaction_nested_events|perfschema\.events_waits_current_MDEV-29091|perfschema\.memory_aggregate_no_a_no_u_no_h|main\.show_explain|main\.show_analyze_json" --max-test-fail=100 --parallel=$(expr %(kw:jobs)s \* 2)',
-                jobs=util.Property("jobs", default="$(getconf _NPROCESSORS_ONLN)"),
-            ),
-        ],
-        timeout=950,
-        haltOnFailure="true",
-        parallel=mtrJobsMultiplier,
-        dbpool=mtrDbPool,
-        autoCreateTables=True,
-        env=MTR_ENV,
-    )
-)
-f_msan_build.addStep(
-    steps.ShellCommand(
-        name="move mysqld log files",
-        alwaysRun=True,
-        command=[
-            "bash",
-            "-c",
-            util.Interpolate(
-                moveMTRLogs(),
-                jobs=util.Property("jobs", default="$(getconf _NPROCESSORS_ONLN)"),
-            ),
-        ],
-    )
-)
-f_msan_build.addStep(
-    steps.ShellCommand(
-        name="create var archive",
-        alwaysRun=True,
-        command=["bash", "-c", util.Interpolate(createVar())],
-        doStepIf=hasFailed,
-    )
-)
-f_msan_build.addStep(
-    steps.DirectoryUpload(
-        name="save mysqld log files",
-        compress="bz2",
-        alwaysRun=True,
-        workersrc="./buildbot/logs/",
-        masterdest=util.Interpolate(
-            "/srv/buildbot/packages/"
-            + "%(prop:tarbuildnum)s"
-            + "/logs/"
-            + "%(prop:buildername)s"
-        ),
-    )
-)
-f_msan_build.addStep(
-    steps.ShellCommand(
-        name="cleanup", command="rm -r * .* 2> /dev/null || true", alwaysRun=True
-    )
-)
 
 ## f_valgrind_build
 f_valgrind_build = util.BuildFactory()
@@ -1502,19 +1382,6 @@ c["builders"].append(
     )
 )
 
-c["builders"].append(
-    util.BuilderConfig(
-        name="amd64-debian-11-msan-clang-16",
-        workernames=workers["x64-bbw-docker-msan-clang-16-debian-11"],
-        tags=["Debian", "quick", "clang-16", "msan", "protected"],
-        collapseRequests=True,
-        nextBuild=nextBuild,
-        canStartBuild=canStartBuild,
-        properties={"c_compiler": "clang-16", "cxx_compiler": "clang++-16"},
-        locks=getLocks,
-        factory=f_msan_build,
-    )
-)
 
 c["builders"].append(
     util.BuilderConfig(