changed return type to bool

Author: varundeepsaini

include/my_sys.h

@@ -17,6 +17,10 @@
 #ifndef _my_sys_h
 #define _my_sys_h
 
+#ifndef __cplusplus
+#include <stdbool.h>
+#endif
+
 #include <m_string.h>
 #include <mysql/psi/mysql_memory.h>
 
@@ -1107,7 +1111,7 @@ int my_msync(int, void *, size_t, int);
 void my_uuid_init(ulong seed1, ulong seed2);
 void my_uuid(uchar *guid);
 void my_uuid_end(void);
-int my_uuid_extract_ts(const char *uuid, my_time_t *seconds, ulong *usec);
+bool my_uuid_extract_ts(const char *uuid, my_time_t *seconds, ulong *usec);
 static inline void my_uuid2str(const uchar *guid, char *s, int with_separators)
 {
   int i;

mysys/my_uuid.c

@@ -39,6 +39,7 @@
                                                      identifier.
 */
 
+#include <stdbool.h>
 #include "mysys_priv.h"
 #include <my_rnd.h>
 #include <m_string.h>
@@ -234,8 +235,8 @@ void my_uuid_end()
   @param[out] usec     Microseconds part
 
   @return
-    @retval 1  Success
-    @retval 0  UUID version doesn't contain timestamp or timestamp invalid
+    @retval false  Success
+    @retval true   UUID version doesn't contain timestamp or timestamp invalid
 
   UUIDv1 format (RFC 4122, big-endian):
     Bytes 0-3:  time_low (32 bits, low part of timestamp)
@@ -247,7 +248,7 @@ void my_uuid_end()
     Bytes 0-5:  Unix timestamp in milliseconds (48 bits)
     Bytes 6-7:  version (4 bits) + sub-millisecond precision (12 bits)
 */
-int my_uuid_extract_ts(const char *uuid, my_time_t *seconds, ulong *usec)
+bool my_uuid_extract_ts(const char *uuid, my_time_t *seconds, ulong *usec)
 {
   uint version= (uchar) uuid[6] >> 4;
   ulonglong ts;
@@ -259,7 +260,7 @@ int my_uuid_extract_ts(const char *uuid, my_time_t *seconds, ulong *usec)
     ts= mi_uint6korr(uuid);
     *seconds= ts / 1000;
     *usec= (ts % 1000) * 1000;
-    return 1;
+    return false;
 
   case 1:
     /*
@@ -275,15 +276,15 @@ int my_uuid_extract_ts(const char *uuid, my_time_t *seconds, ulong *usec)
 
     /* Timestamp before Unix epoch (1970-01-01) */
     if (ts < UUID_TIME_OFFSET)
-      return 0;
+      return true;
 
     ts= (ts - UUID_TIME_OFFSET) / 10;  /* Convert to microseconds */
     *seconds= ts / 1000000;
     *usec= ts % 1000000;
-    return 1;
+    return false;
 
   default:
     /* Other versions (e.g., v4) don't contain timestamps */
-    return 0;
+    return true;
   }
 }

plugin/type_uuid/item_uuidfunc.cc

@@ -47,7 +47,7 @@ bool Item_func_uuid_timestamp::get_timestamp(my_time_t *sec, ulong *usec)
   Type_handler_uuid_new::Fbt_null uuid(args[0]);
   if (uuid.is_null())
     return true;
-  return !my_uuid_extract_ts(uuid.to_lex_cstring().str, sec, usec);
+  return my_uuid_extract_ts(uuid.to_lex_cstring().str, sec, usec);
 }