Skip to content

Commit 3fd03e4

Browse files
committed
MDEV-27675 review fixup
rtree_mbr_from_wkb::n_node: Change the data type from int to uint16_t and pack it together with the added field key_len. In this way, an increase of sizeof(rtree_mbr_from_wkb) will be avoided.
1 parent 413c59d commit 3fd03e4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

storage/innobase/gis/gis0geo.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ pick_next(
445445
double* g1, /*!< in: mbr of group 1. */
446446
double* g2, /*!< in: mbr of group 2. */
447447
rtr_split_node_t** choice, /*!< out: the next node.*/
448-
int* n_group, /*!< out: group number.*/
448+
uint16_t* n_group, /*!< out: 1 or 2 */
449449
int n_dim) /*!< in: dimensions. */
450450
{
451451
rtr_split_node_t* cur = node;
@@ -487,7 +487,7 @@ mark_all_entries(
487487
/*=============*/
488488
rtr_split_node_t* node, /*!< in/out: split nodes. */
489489
int n_entries, /*!< in: entries number. */
490-
int n_group) /*!< in: group number. */
490+
uint16_t n_group) /*!< in: 1 or 2 */
491491
{
492492
rtr_split_node_t* cur = node;
493493
rtr_split_node_t* end = node + n_entries;
@@ -522,7 +522,7 @@ split_rtree_node(
522522
double* g1 = reserve_coords(d_buffer, n_dim);
523523
double* g2 = reserve_coords(d_buffer, n_dim);
524524
rtr_split_node_t* next = NULL;
525-
int next_node = 0;
525+
uint16_t next_node = 0;
526526
int i;
527527
int first_rec_group = 1;
528528
rtr_split_node_t* end = node + n_entries;

storage/innobase/include/gis0geo.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ rtree_mbr_from_wkb(
7070
struct rtr_split_node_t
7171
{
7272
double square; /* square of the mbr.*/
73-
int n_node; /* which group in.*/
74-
uchar* key; /* key. */
73+
uint16_t n_node; /* group: 1 or 2, or 0=unassigned */
7574
uint16_t key_len; /* key length */
75+
uchar* key; /* key. */
7676
double* coords; /* mbr. */
7777
};
7878

0 commit comments

Comments
 (0)