MDEV-37408 Assertion `!thd->is_error()' failed in LEX::make_item_func_or_method_call upon SELECT or WITH

Removing a wrong DBUG_ASSERT from LEX::make_item_func_or_method_call(),
as this method can be called with an already raised SQL error.

Author: abarkov

plugin/type_assoc_array/mysql-test/type_assoc_array/sp-assoc-array-bugs.result

@@ -0,0 +1,23 @@
+SET sql_mode=ORACLE;
+#
+# MDEV-37408 Assertion `!thd->is_error()' failed in LEX::make_item_func_or_method_call upon SELECT or WITH
+#
+WITH w AS (SELECT *)
+SELECT * FROM t WHERE c HAVING 1 WINDOW t AS ()
+ORDER BY 1, 1=ANY(SELECT * LIMIT 1), t.t();
+ERROR 42000: This version of MariaDB doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'
+DECLARE
+TYPE arr_t IS TABLE OF INT INDEX BY INT;
+arr arr_t;
+BEGIN
+WITH w AS (SELECT *) SELECT * FROM t
+WHERE c HAVING 1 WINDOW t AS ()
+ORDER BY 1, 1=ANY(SELECT * LIMIT 1), arr.t();
+END;
+$$
+ERROR 42000: This version of MariaDB doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'
+SHOW WARNINGS;
+Level	Code	Message
+Error	1235	This version of MariaDB doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'
+Error	1305	FUNCTION arr.t does not exist
+# End of 12.1 bugs

plugin/type_assoc_array/mysql-test/type_assoc_array/sp-assoc-array-bugs.test

@@ -0,0 +1,26 @@
+SET sql_mode=ORACLE;
+
+--echo #
+--echo # MDEV-37408 Assertion `!thd->is_error()' failed in LEX::make_item_func_or_method_call upon SELECT or WITH
+--echo #
+
+--error ER_NOT_SUPPORTED_YET
+WITH w AS (SELECT *)
+SELECT * FROM t WHERE c HAVING 1 WINDOW t AS ()
+ORDER BY 1, 1=ANY(SELECT * LIMIT 1), t.t();
+
+DELIMITER $$;
+--error ER_NOT_SUPPORTED_YET
+DECLARE
+  TYPE arr_t IS TABLE OF INT INDEX BY INT;
+  arr arr_t;
+BEGIN
+  WITH w AS (SELECT *) SELECT * FROM t
+  WHERE c HAVING 1 WINDOW t AS ()
+  ORDER BY 1, 1=ANY(SELECT * LIMIT 1), arr.t();
+END;
+$$
+DELIMITER ;$$
+SHOW WARNINGS;
+
+--echo # End of 12.1 bugs

sql/sql_lex.cc

@@ -10664,7 +10664,6 @@ Item *LEX::make_item_func_or_method_call(THD *thd,
                                          List<Item> *args,
                                          const Lex_ident_cli_st &query_fragment)
 {
-  DBUG_ASSERT(!thd->is_error());
   const Lex_ident_sys sys_a(thd, &ca), sys_b(thd, &cb);
   if (sys_a.is_null() || sys_b.is_null())
     return nullptr; // EOM