MDEV-34124: Improve sequences replication with Galera

- use shared key for sequence update certification
- employ native replication's code to apply changes for sequences
which handles all corner cases properly
- fix the tests to allow more transactions using sequences to be
accepted

That way the sequence is always updated to the maximum value
independent of the order of updates, and shared certification keys
allow to improve acceptance ratio of concurrent transactions that
use sequences. It's reflected in the test changes.

Author: mariadb-DenisProtivensky

mysql-test/suite/galera/r/galera_sequences.result

@@ -206,7 +206,7 @@ t	CREATE TABLE `t` (
 ) ENGINE=InnoDB SEQUENCE=1
 connection node_1;
 DROP SEQUENCE t;
-CREATE SEQUENCE t INCREMENT BY 1 NOCACHE ENGINE=INNODB;
+CREATE SEQUENCE t INCREMENT BY 0 CACHE 1 ENGINE=INNODB;
 CREATE TABLE t1(a int not null primary key default nextval(t), b int) engine=innodb;
 connection node_2;
 # Wait DDL to replicate

mysql-test/suite/galera/r/galera_sequences_transaction.result

@@ -72,7 +72,7 @@ LASTVAL(s)
 connection node_1a;
 SELECT LASTVAL(s);
 LASTVAL(s)
-79
+81
 connection node_1;
 SELECT * FROM t1;
 f1	f2
@@ -106,7 +106,6 @@ f1	f2
 56	1
 58	1
 60	1
-61	1
 63	1
 65	1
 67	1
@@ -116,6 +115,7 @@ f1	f2
 75	1
 77	1
 79	1
+81	1
 connection node_2;
 SELECT * FROM t1;
 f1	f2
@@ -149,7 +149,6 @@ f1	f2
 56	1
 58	1
 60	1
-61	1
 63	1
 65	1
 67	1
@@ -159,6 +158,7 @@ f1	f2
 75	1
 77	1
 79	1
+81	1
 connection node_1;
 DROP TABLE t1;
 DROP SEQUENCE s;
@@ -299,10 +299,8 @@ connection node_1a;
 ROLLBACK;
 connection node_2;
 COMMIT;
-ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
 connection node_2a;
 ROLLBACK;
-ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
 connection node_2;
 SELECT LASTVAL(s);
 LASTVAL(s)
@@ -332,6 +330,16 @@ f1	f2
 15	1
 17	1
 19	1
+22	1
+24	1
+26	1
+28	1
+30	1
+32	1
+34	1
+36	1
+38	1
+40	1
 connection node_2;
 SELECT * FROM t1;
 f1	f2
@@ -345,6 +353,16 @@ f1	f2
 15	1
 17	1
 19	1
+22	1
+24	1
+26	1
+28	1
+30	1
+32	1
+34	1
+36	1
+38	1
+40	1
 connection node_1;
 DROP TABLE t1;
 DROP SEQUENCE s;

mysql-test/suite/galera/r/mdev-22063.result

@@ -22,7 +22,7 @@ SELECT * FROM t1;
 a
 SELECT * FROM s;
 next_not_cached_value	minimum_value	maximum_value	start_value	increment	cache_size	cycle_option	cycle_count
-1	1	9223372036854775806	1	1	1000	0	0
+1	1	9223372036854775806	1	1	0	0	0
 connection node_1;
 SET GLOBAL WSREP_MODE='REPLICATE_ARIA,REPLICATE_MYISAM';
 DROP TABLE t1;

mysql-test/suite/galera/t/galera_sequences.test

@@ -163,7 +163,8 @@ SHOW CREATE TABLE t;
 
 --connection node_1
 DROP SEQUENCE t;
-CREATE SEQUENCE t INCREMENT BY 1 NOCACHE ENGINE=INNODB;
+# Don't use NOCACHE as it may produce duplicate entries from multiple nodes
+CREATE SEQUENCE t INCREMENT BY 0 CACHE 1 ENGINE=INNODB;
 CREATE TABLE t1(a int not null primary key default nextval(t), b int) engine=innodb;
 
 --connection node_2
@@ -193,15 +194,11 @@ SET SESSION wsrep_sync_wait=0;
 while ($count)
 {
 --connection node_1
---error 0,ER_LOCK_WAIT_TIMEOUT,ER_LOCK_DEADLOCK
 INSERT INTO t1(b) values (1);
 --connection node_2
---error 0,ER_LOCK_WAIT_TIMEOUT,ER_LOCK_DEADLOCK
 INSERT INTO t1(b) values (2);
---error 0,ER_LOCK_WAIT_TIMEOUT,ER_LOCK_DEADLOCK
 INSERT INTO t1(b) values (2);
 --connection node_1
---error 0,ER_LOCK_WAIT_TIMEOUT,ER_LOCK_DEADLOCK
 INSERT INTO t1(b) values (1);
 --dec $count
 }
@@ -251,15 +248,11 @@ SET SESSION wsrep_sync_wait=0;
 while ($count)
 {
 --connection node_1
---error 0,ER_LOCK_WAIT_TIMEOUT,ER_LOCK_DEADLOCK
 INSERT INTO t1(b) values (1),(2),(3),(4),(5),(6),(7),(8),(9);
 --connection node_2
---error 0,ER_LOCK_WAIT_TIMEOUT,ER_LOCK_DEADLOCK
 INSERT INTO t1(b) values (21),(22),(23),(24),(25),(26),(27),(28),(29);
---error 0,ER_LOCK_WAIT_TIMEOUT,ER_LOCK_DEADLOCK
 INSERT INTO t1(b) values (21),(22),(23),(24),(25),(26),(27),(28),(29);
 --connection node_1
---error 0,ER_LOCK_WAIT_TIMEOUT,ER_LOCK_DEADLOCK
 INSERT INTO t1(b) values (1),(2),(3),(4),(5),(6),(7),(8),(9);
 --dec $count
 }

mysql-test/suite/galera/t/galera_sequences_transaction.test

@@ -230,10 +230,8 @@ COMMIT;
 --connection node_1a
 ROLLBACK;
 --connection node_2
---error ER_LOCK_DEADLOCK
 COMMIT;
 --connection node_2a
---error ER_LOCK_DEADLOCK
 ROLLBACK;
 
 --connection node_2

sql/log_event_server.cc

@@ -7928,15 +7928,21 @@ int Rows_log_event::update_sequence()
   bool old_master= false;
   int err= 0;
 
-  if (!bitmap_is_set(table->rpl_write_set, MIN_VALUE_FIELD_NO) ||
-      (
-#if defined(WITH_WSREP)
-       ! WSREP(thd) &&
+  rpl_group_info *table_rgi=
+#ifdef WITH_WSREP
+  WSREP(thd) ? thd->wsrep_rgi :
 #endif
-       table->in_use->rgi_slave &&
-       !(table->in_use->rgi_slave->gtid_ev_flags2 & Gtid_log_event::FL_DDL) &&
+  table->in_use->rgi_slave;
+  rpl_group_info *thd_rgi=
+#ifdef WITH_WSREP
+  WSREP(thd) ? thd->wsrep_rgi :
+#endif
+  thd->rgi_slave;
+  if (!bitmap_is_set(table->rpl_write_set, MIN_VALUE_FIELD_NO) ||
+      (table_rgi &&
+       !(table_rgi->gtid_ev_flags2 & Gtid_log_event::FL_DDL) &&
        !(old_master=
-         rpl_master_has_bug(thd->rgi_slave->rli,
+         rpl_master_has_bug(thd_rgi->rli,
                             29621, FALSE, FALSE, FALSE, TRUE))))
   {
     /* This event come from a setval function executed on the master.

storage/innobase/handler/ha_innodb.cc

@@ -8473,12 +8473,15 @@ wsrep_calc_row_hash(
 	return(0);
 }
 
-/** Append table-level exclusive key.
+/** Append table-level exclusive/shared key.
 @param thd   MySQL thread handle
 @param table table
+@param exclusive Exclusive not shared certification key.
 @retval false on success
 @retval true on failure */
-ATTRIBUTE_COLD bool wsrep_append_table_key(MYSQL_THD thd, const dict_table_t &table)
+ATTRIBUTE_COLD bool wsrep_append_table_key(MYSQL_THD thd,
+                                           const dict_table_t &table,
+                                           bool exclusive)
 {
   char db_buf[NAME_LEN + 1];
   char tbl_buf[NAME_LEN + 1];
@@ -8491,9 +8494,11 @@ ATTRIBUTE_COLD bool wsrep_append_table_key(MYSQL_THD thd, const dict_table_t &ta
     return true;
   }
 
-  /* Append table-level exclusive key */
-  const int rcode = wsrep_thd_append_table_key(thd, db_buf,
-                                               tbl_buf, WSREP_SERVICE_KEY_EXCLUSIVE);
+  /* Append table-level key */
+  const enum Wsrep_service_key_type key_type = exclusive
+                                               ? WSREP_SERVICE_KEY_EXCLUSIVE
+                                               : WSREP_SERVICE_KEY_SHARED;
+  const int rcode = wsrep_thd_append_table_key(thd, db_buf, tbl_buf, key_type);
   if (rcode)
   {
     WSREP_ERROR("Appending table key failed: %s, %d",
@@ -8656,10 +8661,10 @@ ha_innobase::update_row(
 	    && (thd_sql_command(m_user_thd) != SQLCOM_LOAD ||
 	        thd_binlog_format(m_user_thd) == BINLOG_FORMAT_ROW)) {
 
-		/* We use table-level exclusive key for SEQUENCES
+		/* We use table-level shared key for SEQUENCES
 		   and normal key append for others. */
 		if (table->s->table_type == TABLE_TYPE_SEQUENCE) {
-			if (wsrep_append_table_key(m_user_thd, *m_prebuilt->table))
+			if (wsrep_append_table_key(m_user_thd, *m_prebuilt->table, false))
 				DBUG_RETURN(HA_ERR_INTERNAL_ERROR);
 		} else if (wsrep_append_keys(m_user_thd,
 					     wsrep_protocol_version >= 4

storage/innobase/include/ha_prototypes.h

@@ -406,13 +406,15 @@ char *dict_table_lookup(LEX_CSTRING db, LEX_CSTRING name,
                         dict_table_t **table, mem_heap_t *heap) noexcept;
 
 #ifdef WITH_WSREP
-/** Append table-level exclusive key.
+/** Append table-level exclusive/shared key.
 @param thd   MySQL thread handle
 @param table table
+@param exclusive Exclusive not shared certification key.
 @retval false on success
 @retval true on failure */
 struct dict_table_t;
-bool wsrep_append_table_key(MYSQL_THD thd, const dict_table_t &table);
+bool wsrep_append_table_key(MYSQL_THD thd, const dict_table_t &table,
+                            bool exclusive);
 #endif /* WITH_WSREP */
 
 #endif /* !UNIV_INNOCHECKSUM */

storage/innobase/row/row0ins.cc

@@ -2798,7 +2798,7 @@ row_ins_clust_index_entry_low(
 			}
 #ifdef WITH_WSREP
 			if (trx->is_wsrep() &&
-			    wsrep_append_table_key(trx->mysql_thd, *index->table))
+			    wsrep_append_table_key(trx->mysql_thd, *index->table, true))
 			{
 				trx->error_state = DB_ROLLBACK;
 				goto err_exit;