Add NRT to Csla.Windows (#4678)

* Add NRT to Csla.Windows
#1233

* Track nrt progress

Author: StefanOssendorf

Source/Csla.Windows/ApplicationContextManager.cs

@@ -5,6 +5,7 @@
 // </copyright>
 // <summary>Provides consistent context information between the client</summary>
 //-----------------------------------------------------------------------
+using System.Diagnostics.CodeAnalysis;
 using System.Security.Principal;
 using Csla.Configuration;
 
@@ -16,7 +17,7 @@ namespace Csla.Windows
   /// <param name="securityOptions"></param>
   public class ApplicationContextManager(SecurityOptions securityOptions) : Csla.Core.ApplicationContextManager
   {
-    private static IPrincipal _principal;
+    private static IPrincipal _principal = default!;
     private SecurityOptions _securityOptions = securityOptions;
 
     /// <summary>
@@ -37,6 +38,7 @@ public override IPrincipal GetUser()
     }
 
     /// <inheritdoc />
+    [MemberNotNull(nameof(_principal))]
     public override void SetUser(IPrincipal principal)
     {
       _principal = principal ?? throw new ArgumentNullException(nameof(principal));

Source/Csla.Windows/BindingSourceHelper.cs

@@ -17,7 +17,7 @@ namespace Csla.Windows;
 /// </summary>
 public static class BindingSourceHelper
 {
-  private static BindingSourceNode _rootSourceNode;
+  private static BindingSourceNode _rootSourceNode = default!;
 
   /// <summary>
   /// Sets up BindingSourceNode objects for all
@@ -30,9 +30,11 @@ public static class BindingSourceHelper
   /// <param name="rootSource">
   /// Root BindingSource object.
   /// </param>
-  public static BindingSourceNode InitializeBindingSourceTree(
-    IContainer container, BindingSource rootSource)
+  /// <exception cref="ArgumentNullException"><paramref name="rootSource"/> or <paramref name="container"/> is <see langword="null"/>.</exception>
+  public static BindingSourceNode InitializeBindingSourceTree(IContainer container, BindingSource rootSource)
   {
+    if (container is null)
+      throw new ArgumentNullException(nameof(container));
     if (rootSource == null)
       throw new ApplicationException(Resources.BindingSourceNotProvided);
 
@@ -42,13 +44,11 @@ public static BindingSourceNode InitializeBindingSourceTree(
     return _rootSourceNode;
   }
 
-  private static IEnumerable<BindingSourceNode> GetChildBindingSources(
-    IContainer container, BindingSource parent, BindingSourceNode parentNode)
+  private static IEnumerable<BindingSourceNode> GetChildBindingSources(IContainer container, BindingSource parent, BindingSourceNode parentNode)
   {
     foreach (Component component in container.Components)
     {
-      if (component is BindingSource {DataSource: not null} source &&
-          source.DataSource.Equals(parent))
+      if (component is BindingSource { DataSource: not null } source && source.DataSource.Equals(parent))
       {
         var childNode = new BindingSourceNode(source)
         {

Source/Csla.Windows/BindingSourceNode.cs

@@ -17,52 +17,39 @@ namespace Csla.Windows
   /// </summary>
   public class BindingSourceNode
   {
+    internal BindingSource Source { get; }
+
+    internal List<BindingSourceNode> Children { get; } = [];
+
+    internal BindingSourceNode? Parent { get; set; }
+
     /// <summary>
     /// Creates an instance of the object.
     /// </summary>
     /// <param name="source">
     /// BindingSource object to be managed.
     /// </param>
+    /// <exception cref="ArgumentNullException"><paramref name="source"/> is <see langword="null"/>.</exception>
     public BindingSourceNode(BindingSource source)
     {
-      Source = source;
+      Source = source ?? throw new ArgumentNullException(nameof(source));
       Source.CurrentChanged += BindingSource_CurrentChanged;
     }
 
-    private List<BindingSourceNode> _children;
-
-    private void BindingSource_CurrentChanged(object sender, EventArgs e)
+    private void BindingSource_CurrentChanged(object? sender, EventArgs e)
     {
-      if (_children.Count > 0)
-        foreach (BindingSourceNode child in _children)
+      if (Children.Count > 0)
+        foreach (BindingSourceNode child in Children)
           child.Source.EndEdit();
     }
 
-    internal BindingSource Source { get; }
-
-    internal List<BindingSourceNode> Children
-    {
-      get
-      {
-        if (_children == null)
-          _children = new List<BindingSourceNode>();
-
-        return _children;
-      }
-    }
-
-    internal BindingSourceNode Parent { get; set; }
-
     internal void Unbind(bool cancel)
     {
-      if (Source == null)
-        return;
-
-      if (_children.Count > 0)
-        foreach (BindingSourceNode child in _children)
+      if (Children.Count > 0)
+        foreach (BindingSourceNode child in Children)
           child.Unbind(cancel);
 
-      IEditableObject current = Source.Current as IEditableObject;
+      IEditableObject? current = Source.Current as IEditableObject;
 
       if (!(Source.DataSource is BindingSource))
         Source.DataSource = null;
@@ -75,41 +62,32 @@ internal void Unbind(bool cancel)
           current.EndEdit();
       }
 
-      if (Source.DataSource is BindingSource)
+      if (Source.DataSource is BindingSource && Parent is not null)
         Source.DataSource = Parent.Source;
     }
 
     internal void EndEdit()
     {
-      if (Source == null)
-        return;
-
-      if (_children.Count > 0)
-        foreach (BindingSourceNode child in _children)
+      if (Children.Count > 0)
+        foreach (BindingSourceNode child in Children)
           child.EndEdit();
 
       Source.EndEdit();
     }
 
     internal void SetEvents(bool value)
     {
-      if (Source == null)
-        return;
-
       Source.RaiseListChangedEvents = value;
 
-      if (_children.Count > 0)
-        foreach (BindingSourceNode child in _children)
+      if (Children.Count > 0)
+        foreach (BindingSourceNode child in Children)
           child.SetEvents(value);
     }
 
     internal void ResetBindings(bool refreshMetadata)
     {
-      if (Source == null)
-        return;
-
-      if (_children.Count > 0)
-        foreach (BindingSourceNode child in _children)
+      if (Children.Count > 0)
+        foreach (BindingSourceNode child in Children)
           child.ResetBindings(refreshMetadata);
 
       Source.ResetBindings(refreshMetadata);
@@ -121,7 +99,7 @@ internal void ResetBindings(bool refreshMetadata)
     /// <param name="objectToBind">
     /// Business object.
     /// </param>
-    public void Bind(object objectToBind)
+    public void Bind(object? objectToBind)
     {
       if (objectToBind is ISupportUndo root)
         root.BeginEdit();
@@ -138,7 +116,7 @@ public void Apply()
     {
       SetEvents(false);
 
-      ISupportUndo root = Source.DataSource as ISupportUndo;
+      ISupportUndo? root = Source.DataSource as ISupportUndo;
 
       Unbind(false);
       EndEdit();
@@ -150,11 +128,11 @@ public void Apply()
     /// Cancels changes to the business object.
     /// </summary>
     /// <param name="businessObject"></param>
-    public void Cancel(object businessObject)
+    public void Cancel(object? businessObject)
     {
       SetEvents(false);
 
-      ISupportUndo root = Source.DataSource as ISupportUndo;
+      ISupportUndo? root = Source.DataSource as ISupportUndo;
 
       Unbind(true);